Some revisions to the cpp-tutorial lessions#60
Open
Magnus-Mage wants to merge 1 commit intoTCCPP:mainfrom
Open
Some revisions to the cpp-tutorial lessions#60Magnus-Mage wants to merge 1 commit intoTCCPP:mainfrom
Magnus-Mage wants to merge 1 commit intoTCCPP:mainfrom
Conversation
eisenwave
suggested changes
Sep 19, 2025
Contributor
eisenwave
left a comment
eisenwave
left a comment
There was a problem hiding this comment.
Besides the errors marked in the review comments, I feel like most of the changes are time-wasting and matters of taste.
There is no clear benefit to rewrite "experience compilation errors" to "end up with compilation errors". It's just a rewrite to suit one person's personal tastes over those of the original author.
wiki/cpp-tutorial/language-basics.md
Outdated
Comment on lines
52
to
53
| _Block comments_ start with `/*` and end with `*/`. Although they can be used for single line comments, they are | ||
| typically used for comments that span multiple lines. |
Contributor
There was a problem hiding this comment.
Suggested change
| _Block comments_ start with `/*` and end with `*/`. Although they can be used for single line comments, they are | |
| typically used for comments that span multiple lines. | |
| _Block comments_ start with `/*` and end with `*/`. Although they can be used for single-line comments, they are | |
| typically used for comments that span multiple lines. |
wiki/cpp-tutorial/language-basics.md
Outdated
Comment on lines
84
to
85
| In above snippet, the variable `foo` is initialized with a value of `0`. The expression `foo + 2` is then | ||
| evaluated, and then the result is assigned back to `foo`. |
Contributor
There was a problem hiding this comment.
Suggested change
| In above snippet, the variable `foo` is initialized with a value of `0`. The expression `foo + 2` is then | |
| evaluated, and then the result is assigned back to `foo`. | |
| In the above snippet, the variable `foo` is initialized with a value of `0`. The expression `foo + 2` is then | |
| evaluated, and then the result is assigned back to `foo`. |
wiki/cpp-tutorial/language-basics.md
Outdated
| C++ reserves a set of words in the language for its own use. Developers may use these keywords, but they cannot be used | ||
| as identifiers. You can find a list of all keywords on [cppreference](https://en.cppreference.com/w/cpp/keyword). | ||
| C++ reserves a set of words in the language for its own use, known as _keywords_. These keywords may be used | ||
| by developers, but they cannot be used as identifiers(such as variable name). You can find a complete list of C++ |
Contributor
There was a problem hiding this comment.
Suggested change
| by developers, but they cannot be used as identifiers(such as variable name). You can find a complete list of C++ | |
| by developers, but they cannot be used as identifiers (such as variable names). You can find a complete list of C++ |
wiki/cpp-tutorial/language-basics.md
Outdated
|
|
||
| In addition to these "true keywords", C++ also has "contextual keywords", formally called _identifiers with special | ||
| meaning_, such as `override`. We will cover these in later chapters. | ||
| In addition to these _true keywords_, C++ also has _contextual keywords_, formally called _identifiers with special |
Contributor
There was a problem hiding this comment.
I don't see why this should be italicized. "True keywords" and "contextual keywords" are colloquial terms, and my impression is that we use italics only for proper definitions.
wiki/cpp-tutorial/language-basics.md
Outdated
| ## Fundamental Data Types and Literals | ||
|
|
||
| All values in C++ have a _type_, and variables can only hold values of a specified type. | ||
| In C++, every values has a _type_, and variables can only store values of the type they are declared with. |
Contributor
There was a problem hiding this comment.
Suggested change
| In C++, every values has a _type_, and variables can only store values of the type they are declared with. | |
| In C++, all values has a _type_, and variables can only store values of the type they are declared with. |
wiki/cpp-tutorial/language-basics.md
Outdated
|
|
||
| ```cpp | ||
| bool b = 1 > 0; // True if one is greater than zero. | ||
| bool b = 1 > 0; // true, if 1 is greater than 0. |
Contributor
There was a problem hiding this comment.
The added comma doesn't make sense.
wiki/cpp-tutorial/language-basics.md
Outdated
Comment on lines
164
to
165
| _Integer types_ in C++ are similar to whole numbers in mathematics. They can store values like `1`, `0` or `-1`, | ||
| but nto fractions like 0.5. |
Contributor
There was a problem hiding this comment.
"whole numbers" seems weird. "Integer" is also the term used in mathematics; the original was fine.
wiki/cpp-tutorial/language-basics.md
Outdated
Comment on lines
164
to
165
| _Integer types_ in C++ are similar to whole numbers in mathematics. They can store values like `1`, `0` or `-1`, | ||
| but nto fractions like 0.5. |
Contributor
There was a problem hiding this comment.
Suggested change
| _Integer types_ in C++ are similar to whole numbers in mathematics. They can store values like `1`, `0` or `-1`, | |
| but nto fractions like 0.5. | |
| but to fractions like `0.5`. |
Magnus-Mage
force-pushed
the
fix/revision-cpp-tutorial
branch
3 times, most recently
from
b061934 to
5422fc6
Compare
Author
|
Basically, some of the parts i have revised to use points rather than paragraphs but they are also just a personal preference of what i believe would be easier to read. Otherwise, all other changes should be good. |
Magnus-Mage
force-pushed
the
fix/revision-cpp-tutorial
branch
from
5422fc6 to
7d81df2
Compare
* wiki/wiki/cpp-tutorial/language-basics.md: Typo and corrections to context flow Sign off: Magnus-Mage <>
Magnus-Mage
force-pushed
the
fix/revision-cpp-tutorial
branch
from
7d81df2 to
844c096
Compare
Magnus-Mage
commented
Sep 19, 2025
Author
Magnus-Mage
left a comment
Magnus-Mage
left a comment
There was a problem hiding this comment.
Should be fine with the fomratting now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files changed:
Sign off: Magnus-Mage <>