Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created constraintDecl #2596

Closed
wants to merge 1 commit into from
Closed

Created constraintDecl #2596

wants to merge 1 commit into from

Conversation

raffazizzi
Copy link
Contributor

This is an initial implementation to address #2330. I would like some input on a couple of things.

  • I made <anyElement/> optional in the content of constraintDecl. I think the element can be empty if all that's needed is specifying the query language binding.
  • I allowed constraintDecl in encodingDesc to interleave with other elements. OK?
  • schemaSpec has a <sequence> content model, so I couldn't interleave constraintDecl. Instead, I placed if after elements that typically go first (equiv, desc), but before spec / ref elements. Thoughts?
  • I would appreciate feedback on the text I added to Chap 22 and whether it's in the right place.



<sequence preserveOrder="false">
<alternate minOccurs="1" maxOccurs="unbounded">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this seems to result in relaxng that does not represent the ODD's model, but it may be a separate issue.

Expected:

<interleave>
  <choice>
    <oneOrMore>
      <ref name="model.encodingDescPart"/>  
    </oneOrMore>
    <oneOrMore>
      <ref name="model.pLike"/>
    </oneOrMore>
  </choice>
  <optional>
    <ref name="constraintDecl"/>
  </optional>
</interleave>

Actual:

<interleave>
   <oneOrMore>
      <choice>
         <ref name="model.encodingDescPart"/>
         <ref name="model.pLike"/>
      </choice>
   </oneOrMore>
   <optional>
      <ref name="constraintDecl"/>
   </optional>
</interleave>

@raffazizzi
Copy link
Contributor Author

Closing as duplicate of #2594

@raffazizzi raffazizzi closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant