add PMD check and remove unused variables

TEIC · Jun 1, 2023 · b34359f · b34359f
1 parent cc7164f
commit b34359f
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 39 deletions.
diff --git a/pom.xml b/pom.xml
@@ -159,6 +159,24 @@
           <finalName>${project.artifactId}-${project.version}</finalName>
         </configuration>
       </plugin>-->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-pmd-plugin</artifactId>
+        <version>3.13.0</version>
+        <configuration>
+            <failOnViolation>false</failOnViolation>
+            <printFailingErrors>true</printFailingErrors>
+            <linkXRef>false</linkXRef>
+        </configuration>
+        <executions>
+          <execution>
+            <phase>compile</phase>
+            <goals>
+              <goal>check</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
   </build>
   <dependencies>

diff --git a/src/main/java/pl/psnc/dl/ege/webapp/servlet/ConversionServlet.java b/src/main/java/pl/psnc/dl/ege/webapp/servlet/ConversionServlet.java
@@ -10,7 +10,6 @@
 import javax.ws.rs.GET;
 import javax.ws.rs.POST;
 import javax.ws.rs.Path;
-import javax.ws.rs.PathParam;
 
 
 import io.swagger.v3.oas.annotations.ExternalDocumentation;
@@ -26,8 +25,6 @@
 
 import io.swagger.v3.oas.annotations.responses.ApiResponse;
 import io.swagger.v3.oas.annotations.tags.Tag;
-import org.apache.logging.log4j.Logger;
-import org.apache.logging.log4j.LogManager;
 
 import org.json.XML;
 
@@ -57,24 +54,6 @@
 )
 public class ConversionServlet extends HttpServlet {
 
-	private static final String imagesDirectory = "media";
-
-	private static final String EZP_EXT = ".ezp";
-
-	private static final String FORMAT_DOCX = "docx";
-
-	private static final String FORMAT_ODT = "oo";
-
-	private static final String APPLICATION_MSWORD = "application/msword";
-
-	private static final String APPLICATION_EPUB = "application/epub+zip";
-
-	private static final String APPLICATION_ODT = "application/vnd.oasis.opendocument.text";
-
-	private static final String APPLICATION_OCTET_STREAM = "application/octet-stream";
-
-	private static final Logger LOGGER = LogManager.getLogger(ConversionServlet.class);
-
 	private static final long serialVersionUID = 1L;
 
 	public static final String SLASH = "/";
@@ -83,16 +62,8 @@ public class ConversionServlet extends HttpServlet {
 
 	public static final String SEMICOLON = ";";
 
-	public static final String R_WRONG_METHOD = "Wrong method: GET, expected: POST.";
-
 	public static final String CONVERSIONS_SLICE_BASE = "Conversions/";
 
-	public static final String ZIP_EXT = ".zip";
-
-	public static final String DOCX_EXT = ".docx";
-
-	public static final String EPUB_EXT = ".epub";
-
 	public static final String ODT_EXT = ".odt";
 
 	Conversion conversion;
@@ -102,7 +73,6 @@ public class ConversionServlet extends HttpServlet {
 	 */
 	public ConversionServlet() {
 		super();
-		Conversion conversion = new Conversion();
 	}
 
     /**

diff --git a/src/main/java/pl/psnc/dl/ege/webapp/servlet/CustomizationServlet.java b/src/main/java/pl/psnc/dl/ege/webapp/servlet/CustomizationServlet.java
@@ -8,8 +8,6 @@
 import io.swagger.v3.oas.annotations.media.Schema;
 import io.swagger.v3.oas.annotations.responses.ApiResponse;
 import io.swagger.v3.oas.annotations.tags.Tag;
-import org.apache.logging.log4j.Logger;
-import org.apache.logging.log4j.LogManager;
 import org.json.XML;
 import pl.psnc.dl.ege.webapp.servlethelpers.Customization;
 
@@ -28,9 +26,6 @@
 })
 public class CustomizationServlet extends HttpServlet {
 
-    private static final Logger LOGGER = LogManager
-            .getLogger(CustomizationServlet.class);
-
     private static final long serialVersionUID = 1L;
 
     Customization customization = new Customization();

diff --git a/src/main/java/pl/psnc/dl/ege/webapp/servlet/ValidationServlet.java b/src/main/java/pl/psnc/dl/ege/webapp/servlet/ValidationServlet.java
@@ -18,8 +18,6 @@
 import io.swagger.v3.oas.annotations.media.Schema;
 import io.swagger.v3.oas.annotations.responses.ApiResponse;
 import io.swagger.v3.oas.annotations.tags.Tag;
-import org.apache.logging.log4j.Logger;
-import org.apache.logging.log4j.LogManager;
 
 
 import pl.psnc.dl.ege.types.DataType;
@@ -37,8 +35,6 @@ public class ValidationServlet
 	extends HttpServlet
 {
 
-	private static final Logger LOGGER = LogManager
-			.getLogger(ValidationServlet.class);
 
 	private static final long serialVersionUID = 1L;