Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sphinx-autobuild infinite loop bug #31

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Conversation

bckohan
Copy link
Contributor

@bckohan bckohan commented Mar 5, 2024

Hey @tasansal - looks to me like its this jupyter notebook thats causing the infinite loop for sphinx-autobuild. Let me know if this works for you!

@tasansal
Copy link
Contributor

tasansal commented Mar 5, 2024

Thanks @bckohan, I really appreciate you looking at this. I will check and merge.

This is very strange because the whole "jupyter_execute" directory is in the ignore list here.

Would you mind sharing how you debug this? I've been banging my head against the wall for the past couple days :-)

I thought it was mainly due to sphinx-typer interaction based on the messages I was getting.

@bckohan
Copy link
Contributor Author

bckohan commented Mar 5, 2024

Screenshot 2024-03-05 at 3 26 42 PM

It was calling out this file specifically - maybe exclude_patterns is ignored by sphinx-autobuild? Who knows??

Glad I could help - sometimes you just need a second pair of eyes.

@bckohan
Copy link
Contributor Author

bckohan commented Mar 5, 2024

It does look like sphinx-autobuild ignores exclude_patterns. Here's an open PR to even fix that issue: sphinx-doc/sphinx-autobuild#135

@tasansal
Copy link
Contributor

tasansal commented Mar 5, 2024

It does look like sphinx-autobuild ignores exclude_patterns. Here's an open PR to even fix that issue: sphinx-doc/sphinx-autobuild#135

I don't know what to say, good spy craft :) Thanks a bunch again.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.23%. Comparing base (e55c0a1) to head (f505723).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   84.23%   84.23%           
=======================================
  Files          31       31           
  Lines        1104     1104           
  Branches      139      139           
=======================================
  Hits          930      930           
  Misses        152      152           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tasansal tasansal added the documentation Improvements or additions to documentation label Mar 6, 2024
@tasansal tasansal self-requested a review March 6, 2024 00:00
@tasansal tasansal merged commit 9eaa4ed into TGSAI:main Mar 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants