-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sphinx-autobuild infinite loop bug #31
Conversation
Thanks @bckohan, I really appreciate you looking at this. I will check and merge. This is very strange because the whole "jupyter_execute" directory is in the ignore list here. Would you mind sharing how you debug this? I've been banging my head against the wall for the past couple days :-) I thought it was mainly due to sphinx-typer interaction based on the messages I was getting. |
It does look like sphinx-autobuild ignores exclude_patterns. Here's an open PR to even fix that issue: sphinx-doc/sphinx-autobuild#135 |
I don't know what to say, good spy craft :) Thanks a bunch again. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=======================================
Coverage 84.23% 84.23%
=======================================
Files 31 31
Lines 1104 1104
Branches 139 139
=======================================
Hits 930 930
Misses 152 152
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Hey @tasansal - looks to me like its this jupyter notebook thats causing the infinite loop for sphinx-autobuild. Let me know if this works for you!