Skip to content

Conversation

@vincentvanhees
Copy link
Contributor

@vincentvanhees vincentvanhees commented Aug 19, 2022

This PR adds timezone handling, see issue #43.

  1. Two new input arguments:
  • configtz => the timezone where the accelerometer was configured.
  • desiredtz => the timezone where the accelerometer was worn.

I am using the names configtz and desiredtz because that is the terminology I have been using in R package GGIR. However, we are of course not bound by those names. So, if you prefer alternative more intuitive names then we can do that. For example: tz_worn and tz_config.

  1. To preserve consistency with previous read.gt3x releases, the default behaviour with configtz=NULL and desiredtz=NULL leaves default tz GMT untouched.
  2. Added unit tests for timestamp covering both old- and new .gt3x format.
  3. Gives warning when only one of the two timezone arguments is specified, and then assumes that the unspecified tz equals the specified tz.
  4. Gives error if timezone name is not in OlsenNames().
  5. Added unit tests for this warning (4) and error (5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant