Skip to content

fix(r3,vlm): remove orphaned RoutingReplay from decoder rebuild. #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yxyOo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(r3,vlm): remove orphaned RoutingReplay from decoder rebuild. #1620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions slime/backends/megatron_utils/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,20 @@ def setup_model_and_optimizer(
wrap_model_provider_with_freeze(get_model_provider_func(args, role), args), ModelType.encoder_or_decoder
)

# Some models (e.g., Qwen3VLGPTModel) rebuild the decoder in __init__,
# which causes duplicate RoutingReplay registrations. Rebuild the list from
# the actual model modules to remove orphaned entries.
if os.environ.get("ENABLE_ROUTING_REPLAY", "0") == "1":

from slime.utils.routing_replay import RoutingReplay
active_replays = []
for model_chunk in model:
for module in model_chunk.modules():
if hasattr(module, "routing_replay") and isinstance(module.routing_replay, RoutingReplay):
active_replays.append(module.routing_replay)
if active_replays:
RoutingReplay.all_routing_replays = active_replays

# Optimizer
kwargs = {}
for f in dataclasses.fields(OptimizerConfig):
Expand Down