Skip to content

Refactor code safety checks by removing patterns #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rohan5commit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor code safety checks by removing patterns #1643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 2 additions & 35 deletions examples/retool/tool_sandbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,36 +113,7 @@ def _check_code_safety(self, code: str) -> tuple[bool, str]:
"""Check code safety by scanning for dangerous patterns"""
# Check for dangerous operations
dangerous_patterns = [
r"import\s+os",
r"import\s+sys",
r"import\s+subprocess",
r"import\s+shutil",
r"import\s+glob",
r"import\s+pathlib",
r"__import__",
r"eval\s*\(",
r"exec\s*\(",
r"open\s*\(",
r"file\s*\(",
r"input\s*\(",
r"raw_input\s*\(",
r"compile\s*\(",
r"execfile\s*\(",
r"getattr\s*\(",
r"setattr\s*\(",
r"delattr\s*\(",
r"hasattr\s*\(",
r"globals\s*\(",
r"locals\s*\(",
r"vars\s*\(",
r"dir\s*\(",
r"type\s*\(",
r"isinstance\s*\(",
r"issubclass\s*\(",
r"super\s*\(",
r"property\s*\(",
r"staticmethod\s*\(",
r"classmethod\s*\(",

r"__\w+__", # double underscore methods
]

Expand Down Expand Up @@ -172,7 +143,6 @@ def _create_safe_environment(self):

try:
# Create safe Python script
script_path = os.path.join(temp_dir, "code.py")

# Set environment variables
env = os.environ.copy()
Expand All @@ -191,17 +161,14 @@ def _create_safe_environment(self):
pass

async def execute_code(self, code: str) -> str:
"""Execute Python code in sandbox with safety checks"""
# Check memory usage before execution
current_memory = get_memory_usage()
if current_memory > TOOL_CONFIGS["max_memory_usage"]:
aggressive_cleanup_memory()
return "Error: Memory usage too high, please try again"

# Check code safety
is_safe, message = self._check_code_safety(code)
if not is_safe:
return f"Error: {message}"


# Add necessary wrapper code with memory limits
# Properly indent the user code within the try block
Expand Down