Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnia/feature/fix key name is empty #44

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Omnia/feature/fix key name is empty #44

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5dc96f5
Add action
phuclh May 18, 2021
22546c0
Fix Key Name is empty in Nova
phuclh May 20, 2021
63c0699
Fix styling
phuclh May 20, 2021
180bcfb
Revert "Add action"
phuclh May 20, 2021
f7f66d6
Merge remote-tracking branch 'origin/omnia/feature/fix-key-name-is-em…
phuclh May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Key Name is empty in Nova
  • Loading branch information
@phuclh
phuclh committed May 20, 2021
commit 22546c0084b0e8b4c6350f398919ecaafcebecc8
4 changes: 2 additions & 2 deletions src/Nova/Key.php
View file
Original file line number Diff line number Diff line change
@@ -29,14 +29,14 @@ public function fieldsForIndex(NovaRequest $request)
{
return array_filter([
ID::make()->sortable(),
Text::make('Name')->sortable(),
Text::make('Slug')->sortable(),
]);
}

public function fields(Request $request)
{
return array_filter([
Text::make('Name')->required(),
Text::make('Slug'),

new Panel('Data Fields', $this->dataFields()),
]);