Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interface #32

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Fix interface #32

wants to merge 18 commits into from

Conversation

addman2
Copy link
Contributor

@addman2 addman2 commented Jan 15, 2024

I have two suggestion to change in the fortran interface include file:

  • Rename the qmckl_gpu_f.f90 to *.F90. The later automatically invokes C preprocessor, and it is with align with the naming convetion from qmckl (cpu)
  • Arrays does not have to passed as c_ptr, technically they can have their respective datatypes.

@addman2 addman2 marked this pull request as draft January 15, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant