Added both row-major and column-major representations in documentation. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scemama thanks, indeed, that would make things clear! Should we mention that all languages (C, Python, Rust) except Fortran (not sure about Julia though) are row-major? |
q-posev
approved these changes
Mar 22, 2024
|
I would prefer not. For example, OCaml has both row- or column-major possibilites with Bigarrays. Same for Numpy in Python: with an option you can change to column major. Also, if you use BLAS in C, as BLAS is written in Fortran it stays column-major. But if you use CBlas, it is row-major. So I would not make a generality and let the users check what ordering they should use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent having issues such as #127 and #142.