-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round the punch button to match workday waiver tabs #1155
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. If we are talking about consistency, I think there are other buttons that should get the rounded corners (and ideally they should all be the same ratio):
- Reset button on the preferences window (the day selector already has rounded buttons)
- Waive/Load holidays button on the waiver manager.
186c99f
to
4e26aa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. Thoughts @araujoarthur0 ?
I guess, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @araujoarthur0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Atomic-Germ this seems to have a merge conflict with the other PR I just merged from you. Please rebase and solve them.
Looks good to me! |
\changelog-update |
Related issue
Closes #
Context / Background
What change is being introduced by this PR?