Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round the punch button to match workday waiver tabs #1155

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

Atomic-Germ
Copy link
Contributor

Related issue

Closes #

Context / Background

  • The punch button is currently squared, and other similar elements are not.

What change is being introduced by this PR?

  • Top corners of the punch button get 0.5rem corner radius
Screenshot 2025-02-08 at 12 58 09 PM

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. If we are talking about consistency, I think there are other buttons that should get the rounded corners (and ideally they should all be the same ratio):

  • Reset button on the preferences window (the day selector already has rounded buttons)
  • Waive/Load holidays button on the waiver manager.

@Atomic-Germ
Copy link
Contributor Author

Here's what I've got now:

Screenshot 2025-02-09 at 8 33 23 PM

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Thoughts @araujoarthur0 ?

@araujoarthur0
Copy link
Collaborator

Looks good to me!

Should we also round the rectangular time boxes in preferences?
image

@tupaschoal
Copy link
Collaborator

I guess, right?

@Atomic-Germ
Copy link
Contributor Author

Screenshot 2025-02-11 at 3 21 31 PM

Let's consider if there's anything else that would be well served by softened corners, and whether 0.5rem is right, or too much.

@araujoarthur0
Copy link
Collaborator

araujoarthur0 commented Feb 11, 2025

Screenshot 2025-02-11 at 3 21 31 PM Let's consider if there's anything else that would be well served by softened corners, and whether 0.5rem is right, or too much.

Thanks! I took a general look and only that box sparked my interest. I think the roundness is ok, but the text looks misaligned inside it. Since the text is aligned across the page, we'll have to move the outside box to the right a bit

@Atomic-Germ
Copy link
Contributor Author

Screenshot 2025-02-12 at 8 41 21 AM

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @araujoarthur0 ?

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Atomic-Germ this seems to have a merge conflict with the other PR I just merged from you. Please rebase and solve them.

@araujoarthur0
Copy link
Collaborator

Looks good to me!

@araujoarthur0 araujoarthur0 changed the title round the punch button to match workday waiver tabs Round the punch button to match workday waiver tabs Feb 13, 2025
@tupaschoal tupaschoal merged commit 6c59471 into TTLApp:main Feb 13, 2025
4 checks passed
@tupaschoal
Copy link
Collaborator

\changelog-update
Message: Enhancement [#1155]: Round squared buttons and fields to match app look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants