Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI run on ubuntu-latest again #1161

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

tupaschoal
Copy link
Collaborator

Context / Background

We've been running on ubuntu-20.04 for a while, because it seemed like for latest the CI would hang. That runner is now being deprecated

What change is being introduced by this PR?

Make the CI use ubuntu-latest again, which will make it behave like the other CIs. Hopefully with all the test rewrite we've done, it will just work.

How will this be tested?

Let the CI run :D

@tupaschoal
Copy link
Collaborator Author

Ok, it's failing, seems microsoft/playwright#11932 and microsoft/playwright#34251 might help, will investigate later.

@araujoarthur0
Copy link
Collaborator

Do the tests work in the wsl you created?

@Atomic-Germ
Copy link
Contributor

If we use 22.04.5 LTS instead of latest, it should work according to my own experiments. ubuntu-22.04 isn't losing support like 20.04 is, and seems to be more compatible with our tests

@tupaschoal
Copy link
Collaborator Author

If we use 22.04.5 LTS instead of latest, it should work according to my own experiments. ubuntu-22.04 isn't losing support like 20.04 is, and seems to be more compatible with our tests

I thought about that, but at the same time it doesn't make sense to fix a version just for ubuntu and use latest for the others.

Do the tests work in the wsl you created?

I didn't test

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@tupaschoal
Copy link
Collaborator Author

Apparently the tip on the playwright issue did the trick and everything is running and passing now :)

@tupaschoal tupaschoal merged commit 9631f86 into TTLApp:main Feb 18, 2025
4 checks passed
@tupaschoal tupaschoal deleted the ubunt-latest branch February 18, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants