-
Notifications
You must be signed in to change notification settings - Fork 0
deploy: 3.0.0 배포 (#214) #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9f4aeb4
design: 로그인 팝오버 구현 (#199)
AndyH0ng 43c14d2
feat: 프로젝트 정보 연동 (#199)
AndyH0ng 4cce72d
feat: 프로젝트 max-width 조절 (#199)
AndyH0ng 00c863f
feat: 로그인 UI 디자인 수정 (#199)
AndyH0ng 79a3c5b
feat: 프로젝트 max-width 조절 (#199)
AndyH0ng 433ea6f
feat: 헤더 모바일 레이아웃 구현 (#199)
AndyH0ng d230e43
Merge branch 'develop' into design/login-ui-199
AndyH0ng 2f47c03
feat: 다크모드 토글 추가 (#199)
AndyH0ng 8db5be2
Merge branch 'develop' into design/login-ui-199
AndyH0ng 0ba3b5e
feat: 인스타그램 공유 추가 (#199)
AndyH0ng 7df2cc1
Merge branch 'design/login-ui-199' of https://github.com/TTORANG/Web …
AndyH0ng 3fe94bd
Merge pull request #212 from TTORANG/design/login-ui-199
AndyH0ng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 조건문의
|| pathname.endsWith('/videos')부분은 불필요해 보입니다. 정규식은 이미/:projectId/videos와 같은 경로를 올바르게 처리하고 있습니다.Router.tsx를 보면 최상위/videos경로는 정의되어 있지 않으므로, 이 추가적인 검사가 필요한 경우는 없을 것으로 보입니다. 불필요한 코드를 제거하면 코드가 더 명확해지고 유지보수하기 좋아질 것입니다.