Improve Loading and Error Screens

TUM-Dev · Oct 31, 2024 · f9b63d3 · f9b63d3
1 parent 18e2b9c
commit f9b63d3
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 16 deletions.
diff --git a/lib/campusComponent/view/movie/movies_widget_view.dart b/lib/campusComponent/view/movie/movies_widget_view.dart
@@ -75,18 +75,20 @@ class _MoviesHomeWidgetState extends ConsumerState<MovieWidgetView> {
         withinScrollView: true,
       );
     } else if (snapshot.hasError) {
-      return SizedBox(
-        height: MediaQuery.of(context).size.height * 0.34,
-        child: ErrorHandlingRouter(
-          error: snapshot.error!,
-          errorHandlingViewType: ErrorHandlingViewType.textOnly,
-          retry: (() => ref.read(movieViewModel).fetch(true)),
+      return AspectRatio(
+        aspectRatio: 2,
+        child: Card(
+          child: ErrorHandlingRouter(
+            error: Error(),
+            errorHandlingViewType: ErrorHandlingViewType.textOnly,
+            retry: (() => ref.read(movieViewModel).fetch(true)),
+          ),
         ),
       );
     } else {
-      return Card(
-        child: SizedBox(
-          height: MediaQuery.of(context).size.height * 0.34,
+      return AspectRatio(
+        aspectRatio: 2,
+        child: Card(
           child: DelayedLoadingIndicator(name: context.tr("movies")),
         ),
       );

diff --git a/lib/campusComponent/view/studentClub/student_club_widget_view.dart b/lib/campusComponent/view/studentClub/student_club_widget_view.dart
@@ -63,16 +63,22 @@ class _StudentClubWidgetViewState extends ConsumerState<StudentClubWidgetView> {
               withinScrollView: true,
             );
           } else if (snapshot.hasError) {
-            return Card(
-              child: ErrorHandlingRouter(
-                error: Error(),
-                errorHandlingViewType: ErrorHandlingViewType.textOnly,
+            return AspectRatio(
+              aspectRatio: 2,
+              child: Card(
+                child: ErrorHandlingRouter(
+                  error: Error(),
+                  errorHandlingViewType: ErrorHandlingViewType.textOnly,
+                ),
               ),
             );
           } else {
-            return const Card(
-              child: DelayedLoadingIndicator(
-                name: "Student Clubs",
+            return const AspectRatio(
+              aspectRatio: 2,
+              child: Card(
+                child: DelayedLoadingIndicator(
+                  name: "Student Clubs",
+                ),
               ),
             );
           }