Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for config.htmlTag & page.bodyTagAdd #802

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

twoldanski
Copy link
Collaborator

@twoldanski twoldanski commented Jan 23, 2025

  • By default generate language attributes for html tag based on current language page, so nuxt does not have to do it manually

  • support custom attributes like config.htmlTag.attributes.class = no-js with option to override default attributes

  • Add support for setting body tag attributes via page.bodyTagAdd Typoscript directive, so frontend app can automatically apply it via nuxt feature

@twoldanski twoldanski force-pushed the feat/html-attr branch 2 times, most recently from b6938f0 to fb2e506 Compare January 23, 2025 11:29
@coveralls
Copy link

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 12928430090

Details

  • 10 of 11 (90.91%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 72.915%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Classes/Seo/MetaHandler.php 10 11 90.91%
Totals Coverage Status
Change from base Build 12743549975: 0.1%
Covered Lines: 1093
Relevant Lines: 1499

💛 - Coveralls

- By default generate language attributes for html tag based on current language page, so nuxt does not have to do it manually
- support custom attributes like `config.htmlTag.attributes.class = no-js` with option to override default attributes

- Add support for setting body tag attributes via `page.bodyTagAdd` Typoscript directive, so frontend app can automatically apply it via nuxt feature
@lukaszuznanski lukaszuznanski merged commit 328d11c into master Jan 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants