[TASK] Avoid implicitly nullable method parameter

Implicit nullable method parameters are deprecated with PHP 8.4. The patch prepares affected method signatures.
TYPO3 · Jul 12, 2024 · c672a2e · c672a2e
1 parent 39cc77c
commit c672a2e
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 10 deletions.
diff --git a/src/Behavior/CdataSection.php b/src/Behavior/CdataSection.php
@@ -39,7 +39,7 @@ public function getName(): string
         return '#cdata-section';
     }
 
-    public function handle(NodeInterface $node, ?DOMNode $domNode, Context $context, Behavior $behavior = null): ?DOMNode
+    public function handle(NodeInterface $node, ?DOMNode $domNode, Context $context, ?Behavior $behavior = null): ?DOMNode
     {
         if (!$this->secure || $domNode === null) {
             return $domNode;

diff --git a/src/Behavior/Comment.php b/src/Behavior/Comment.php
@@ -39,7 +39,7 @@ public function getName(): string
         return '#comment';
     }
 
-    public function handle(NodeInterface $node, ?DOMNode $domNode, Context $context, Behavior $behavior = null): ?DOMNode
+    public function handle(NodeInterface $node, ?DOMNode $domNode, Context $context, ?Behavior $behavior = null): ?DOMNode
     {
         if (!$this->secure || $domNode === null) {
             return $domNode;

diff --git a/src/Behavior/Handler/AsTextHandler.php b/src/Behavior/Handler/AsTextHandler.php
@@ -23,7 +23,7 @@
 
 class AsTextHandler implements HandlerInterface
 {
-    public function handle(NodeInterface $node, ?DOMNode $domNode, Context $context, Behavior $behavior = null): ?DOMNode
+    public function handle(NodeInterface $node, ?DOMNode $domNode, Context $context, ?Behavior $behavior = null): ?DOMNode
     {
         if ($domNode === null) {
             return null;

diff --git a/src/Behavior/Handler/ClosureHandler.php b/src/Behavior/Handler/ClosureHandler.php
@@ -34,7 +34,7 @@ public function __construct(Closure $closure)
         $this->closure = $closure;
     }
 
-    public function handle(NodeInterface $node, ?DOMNode $domNode, Context $context, Behavior $behavior = null): ?DOMNode
+    public function handle(NodeInterface $node, ?DOMNode $domNode, Context $context, ?Behavior $behavior = null): ?DOMNode
     {
         $result = call_user_func($this->closure, $node, $domNode, $context, $behavior);
         if ($result !== null && !$result instanceof DOMNode) {

diff --git a/src/Behavior/HandlerInterface.php b/src/Behavior/HandlerInterface.php
@@ -20,5 +20,5 @@
 
 interface HandlerInterface
 {
-    public function handle(NodeInterface $node, ?DOMNode $domNode, Context $context, Behavior $behavior = null): ?DOMNode;
+    public function handle(NodeInterface $node, ?DOMNode $domNode, Context $context, ?Behavior $behavior = null): ?DOMNode;
 }
diff --git a/src/Behavior/Tag.php b/src/Behavior/Tag.php
@@ -62,7 +62,7 @@ class Tag implements NodeInterface
      */
     protected $attrs = [];
 
-    public function __construct(string $name, int $flags = null)
+    public function __construct(string $name, ?int $flags = null)
     {
         $this->name = $name;
         // using `null` as default - potentially allows switching

diff --git a/src/Context.php b/src/Context.php
@@ -32,7 +32,7 @@ class Context
      */
     public $initiator;
 
-    public function __construct(HTML5 $parser, InitiatorInterface $initiator = null)
+    public function __construct(HTML5 $parser, ?InitiatorInterface $initiator = null)
     {
         $this->parser = $parser;
         $this->initiator = $initiator;

diff --git a/src/Sanitizer.php b/src/Sanitizer.php
@@ -92,7 +92,7 @@ public function __construct(...$items)
         $this->parser = $this->createParser();
     }
 
-    public function sanitize(string $html, InitiatorInterface $initiator = null): string
+    public function sanitize(string $html, ?InitiatorInterface $initiator = null): string
     {
         $root = $this->parse($html);
         // @todo drop deprecated property
@@ -109,7 +109,7 @@ protected function parse(string $html): DOMDocumentFragment
         return $this->parser->parseFragment($html);
     }
 
-    protected function handle(DOMNode $domNode, InitiatorInterface $initiator = null): DOMNode
+    protected function handle(DOMNode $domNode, ?InitiatorInterface $initiator = null): DOMNode
     {
         $this->context = new Context($this->parser, $initiator);
         $this->beforeTraverse();
@@ -195,7 +195,7 @@ protected function replaceNode(DOMNode $source, ?DOMNode $target): ?DOMNode
         return $target;
     }
 
-    protected function createRules(InitiatorInterface $initiator = null): Rules
+    protected function createRules(?InitiatorInterface $initiator = null): Rules
     {
         $stream = fopen('php://temp', 'wb');
         return (new Rules($stream, self::mastermindsDefaultOptions))