[TASK] Deprecate getAccessibleMockForAbstractClass
#495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
force-pushed
the
task/deprecate/accessible-mock-for-abstract-class
branch
from
8cf66eb
to
0382402
Compare
|
Stefan, Lolli, would this also make sense for version 7? |
|
I think v8 / main TF should be sufficient?! Not using getMockForAbstractClass() is mainly a task ext authors may/should have to deal with with core 13 and above. since TF 8 will be 'core v12 & v13', we should probably note deprecation of it in TF 8 only. Is that fine, or did I mix up anything? |
|
Yes, that would be fine for me. |
This method uses `getMockForAbstractClass()` under the hood, which in turn has been soft-deprecated in PHPUnit 10.1 and will issue deprecation warnings in PHPUnit 11 and up: sebastianbergmann/phpunit#5241 Releases: main
oliverklee
force-pushed
the
task/deprecate/accessible-mock-for-abstract-class
branch
from
0382402
to
73f574f
Compare
lolli42
approved these changes
Aug 29, 2023
oliverklee
deleted the
task/deprecate/accessible-mock-for-abstract-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method uses
getMockForAbstractClass()under the hood, which in turn has been soft-deprecated in PHPUnit 10.1 and will issue deprecation warnings in PHPUnit 11 and up:sebastianbergmann/phpunit#5241
Releases: main