[TASK] Update all the things (#160)

Executed commands: composer update -W composer t3g:cgl:fix composer t3g:phpstan:create-baseline
TYPO3GmbH · Mar 5, 2024 · 9c7d3b5 · 9c7d3b5
1 parent 9328f3f
commit 9c7d3b5
Show file tree

Hide file tree

Showing 19 changed files with 1,854 additions and 1,438 deletions.
diff --git a/build/phpstan-baseline.neon b/build/phpstan-baseline.neon
@@ -1,6 +1,2 @@
 parameters:
 	ignoreErrors:
-		-
-			message: "#^Result of && is always false\\.$#"
-			count: 1
-			path: ../src/Extractor/DeploymentInformation.php
diff --git a/composer.lock b/composer.lock
diff --git a/legacy_hook/composer.lock b/legacy_hook/composer.lock
diff --git a/src/Controller/DocsRenderingController.php b/src/Controller/DocsRenderingController.php
@@ -355,7 +355,7 @@ public function index(
             );
             $this->entityManager->flush();
 
-            return new Response(null, RESPONSE::HTTP_NO_CONTENT);
+            return new Response(null, Response::HTTP_NO_CONTENT);
         }
     }
 }
diff --git a/src/Controller/GithubRstIssueController.php b/src/Controller/GithubRstIssueController.php
@@ -43,7 +43,7 @@ public function index(Request $request, GithubService $githubService, string $gi
         } catch (DoNotCareException) {
             // Hook payload could not be identified as hook that should trigger git split
         } catch (\JsonException) {
-            return new Response('Invalid JSON', \Symfony\Component\HttpFoundation\Response::HTTP_BAD_REQUEST);
+            return new Response('Invalid JSON', Response::HTTP_BAD_REQUEST);
         }
 
         return new Response();

diff --git a/src/Exception/GithubHookPingException.php b/src/Exception/GithubHookPingException.php
@@ -18,7 +18,7 @@ class GithubHookPingException extends \Exception
 {
     private readonly string $repositoryUrl;
 
-    public function __construct(string $message = '', int $code = 0, \Throwable $previous = null, string $repositoryUrl = '')
+    public function __construct(string $message = '', int $code = 0, ?\Throwable $previous = null, string $repositoryUrl = '')
     {
         parent::__construct($message, $code, $previous);
         $this->repositoryUrl = $repositoryUrl;

diff --git a/src/Extractor/DeploymentInformation.php b/src/Extractor/DeploymentInformation.php
@@ -167,6 +167,7 @@ private function getTargetBranchDirectory(string $branch, string $type): string
             if (!preg_match('/^(\d+.\d+.\d+)$/', $result)) {
                 throw new DocsPackageDoNotCareBranch('Branch / tag named \'' . $branch . '\' is ignored, only tags named \'major.minor.patch\' (e.g. \'5.7.2\') are considered.', 1557498335);
             }
+
             // Remove patch level, '8.7.2' becomes '8.7'
             return implode('.', array_slice(explode('.', $result), 0, 2));
         }

diff --git a/src/Utility/RepositoryUrlUtility.php b/src/Utility/RepositoryUrlUtility.php
@@ -15,7 +15,7 @@
 
 class RepositoryUrlUtility
 {
-    public static function resolveComposerJsonUrl(string $repositoryUrl, string $branch, string $repositoryType = null): string
+    public static function resolveComposerJsonUrl(string $repositoryUrl, string $branch, ?string $repositoryType = null): string
     {
         $url = self::extractComposerJsonUrlFromRepositoryUrl($repositoryUrl, $branch);
         if ('' === $url || GitRepositoryService::SERVICE_BITBUCKET_SERVER === $repositoryType) {

diff --git a/src/Validator/Constraints/InvalidCharacter.php b/src/Validator/Constraints/InvalidCharacter.php
@@ -15,7 +15,6 @@
 
 /**
  * @Annotation
- *
  * @Target({"PROPERTY", "METHOD", "ANNOTATION"})
  */
 #[\Attribute(\Attribute::TARGET_PROPERTY | \Attribute::TARGET_METHOD | \Attribute::IS_REPEATABLE)]

diff --git a/tests/Functional/Fixtures/DocsToBambooBadRequest.php b/tests/Functional/Fixtures/DocsToBambooBadRequest.php
@@ -13,7 +13,7 @@
 
 return Request::create(
     '/docs',
-    \Symfony\Component\HttpFoundation\Request::METHOD_POST,
+    Request::METHOD_POST,
     [],
     [],
     [],

diff --git a/tests/Functional/Fixtures/DocsToBambooGithubDeletedBranchRequest.php b/tests/Functional/Fixtures/DocsToBambooGithubDeletedBranchRequest.php
@@ -13,7 +13,7 @@
 
 return Request::create(
     '/docs',
-    \Symfony\Component\HttpFoundation\Request::METHOD_POST,
+    Request::METHOD_POST,
     [],
     [],
     [],

diff --git a/tests/Functional/Fixtures/DocsToBambooGithubPingRequest.php b/tests/Functional/Fixtures/DocsToBambooGithubPingRequest.php
@@ -13,7 +13,7 @@
 
 return Request::create(
     '/docs',
-    \Symfony\Component\HttpFoundation\Request::METHOD_POST,
+    Request::METHOD_POST,
     [],
     [],
     [],

diff --git a/tests/Functional/Fixtures/DocsToBambooGoodRequest.php b/tests/Functional/Fixtures/DocsToBambooGoodRequest.php
@@ -13,7 +13,7 @@
 
 return Request::create(
     '/docs',
-    \Symfony\Component\HttpFoundation\Request::METHOD_POST,
+    Request::METHOD_POST,
     [],
     [],
     [],

diff --git a/tests/Functional/Fixtures/DocsToBambooGoodRequestMultiBranch.php b/tests/Functional/Fixtures/DocsToBambooGoodRequestMultiBranch.php
@@ -13,7 +13,7 @@
 
 return Request::create(
     '/docs',
-    \Symfony\Component\HttpFoundation\Request::METHOD_POST,
+    Request::METHOD_POST,
     [],
     [],
     [],

diff --git a/tests/Functional/Fixtures/GithubPullRequestBadRequest.php b/tests/Functional/Fixtures/GithubPullRequestBadRequest.php
@@ -13,7 +13,7 @@
 
 return Request::create(
     '/githubpr',
-    \Symfony\Component\HttpFoundation\Request::METHOD_POST,
+    Request::METHOD_POST,
     [],
     [],
     [],

diff --git a/tests/Functional/Fixtures/GithubPullRequestGoodRequest.php b/tests/Functional/Fixtures/GithubPullRequestGoodRequest.php
@@ -13,7 +13,7 @@
 
 return Request::create(
     '/githubpr',
-    \Symfony\Component\HttpFoundation\Request::METHOD_POST,
+    Request::METHOD_POST,
     [],
     [],
     [],

diff --git a/tests/Functional/Fixtures/GithubRstIssuePatchBackportRequest.php b/tests/Functional/Fixtures/GithubRstIssuePatchBackportRequest.php
@@ -13,7 +13,7 @@
 
 return Request::create(
     '/create-rst-issue',
-    \Symfony\Component\HttpFoundation\Request::METHOD_POST,
+    Request::METHOD_POST,
     [],
     [],
     [],

diff --git a/tests/Functional/Fixtures/GithubRstIssuePatchNoDocsChangesRequest.php b/tests/Functional/Fixtures/GithubRstIssuePatchNoDocsChangesRequest.php
@@ -13,7 +13,7 @@
 
 return Request::create(
     '/create-rst-issue',
-    \Symfony\Component\HttpFoundation\Request::METHOD_POST,
+    Request::METHOD_POST,
     [],
     [],
     [],

diff --git a/tests/Functional/Fixtures/GithubRstIssuePatchRequest.php b/tests/Functional/Fixtures/GithubRstIssuePatchRequest.php
@@ -13,7 +13,7 @@
 
 return Request::create(
     '/create-rst-issue',
-    \Symfony\Component\HttpFoundation\Request::METHOD_POST,
+    Request::METHOD_POST,
     [],
     [],
     [],