Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(download): should not error when the model to be removed not existed #3296

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

zwpaper
Copy link
Member

@zwpaper zwpaper commented Oct 21, 2024

after fix:

CleanShot 2024-10-22 at 09 55 27

before:
CleanShot 2024-10-22 at 10 38 47@2x

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 63.60%. Comparing base (096dd20) to head (d2f4c58).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/tabby-download/src/lib.rs 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3296      +/-   ##
==========================================
- Coverage   63.63%   63.60%   -0.04%     
==========================================
  Files         187      187              
  Lines       20813    20820       +7     
==========================================
- Hits        13245    13243       -2     
- Misses       7568     7577       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsxiaoys wsxiaoys changed the title fix: should not error when the model to be removed not existed fix(download): should not error when the model to be removed not existed Oct 21, 2024
@wsxiaoys wsxiaoys merged commit 681dc9d into main Oct 22, 2024
5 of 8 checks passed
@wsxiaoys wsxiaoys deleted the fix/newly-download-multi-model branch October 22, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants