Fix #1239 non-hidden entry query performance issue #1240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #1239 by rewriting the sqlalchemy code that fetches non-hidden entries. Such that references to the main query are no longer used in the sub-query. This is done in 2 steps:
This is done by first querying all tags that are hidden and joining with the TagEntry binding table and selecting only the entry ids.
Previous generated SQL for simple query:
New SQL:
Tasks Completed
Reused existing tests, as this should be a "do the same but faster"