Upgrade HeroIcons library for .NET 9 auto render support#4
Upgrade HeroIcons library for .NET 9 auto render support#4TaylorWatson wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| <EmbeddedResource Include="wwwroot/icons/**/*.svg"> | ||
| <LogicalName>TailBlazor.HeroIcons.icons.%(RecursiveDir)%(Filename)%(Extension)</LogicalName> | ||
| </EmbeddedResource> |
There was a problem hiding this comment.
Align embedded SVG names with lookup format
The project now embeds the SVGs with LogicalName constructed from %(RecursiveDir), which preserves the directory separator. That yields resource names like TailBlazor.HeroIcons.icons.outline/academic-cap.svg, but the runtime lookup in TailBlazorHeroIconBase requests TailBlazor.HeroIcons.icons.{style}.{icon}.svg (dots instead of /). As a result GetManifestResourceStream never finds any icon and the component throws the InvalidOperationException for every render. Replace the slash in %(RecursiveDir) with a dot or adjust the lookup string so the resource names match.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68e70333537483328776f9e43b7a4ce5