-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade TailBlazor progress bar for .NET 9 auto render #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TaylorWatson
wants to merge
1
commit into
main
Choose a base branch
from
codex/upgrade-to-.net-9-and-support-blazor-auto-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| @namespace TailBlazor.ProgressBar | ||
|
|
||
| <div class="overflow-hidden @BackgroundClass"> | ||
| <span class="flex h-@(Height) @Class" style="width:@(_percentage)%"></span> | ||
| <div class="overflow-hidden @(BackgroundClass ?? string.Empty)"> | ||
| <span class="flex h-@(Height) @(Class ?? string.Empty)" style="width:@(_percentage)%"></span> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,20 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using Microsoft.AspNetCore.Components; | ||
|
|
||
| namespace TailBlazor.ProgressBar | ||
| { | ||
| public partial class TailBlazorProgressBar | ||
| { | ||
| [Parameter] public string Class { get; set; } = "rounded bg-gradient-to-br animate-pulse from-purple-500 to-red-600"; | ||
| [Parameter] public string? Class { get; set; } = "rounded bg-gradient-to-br animate-pulse from-purple-500 to-red-600"; | ||
| [Parameter] public int Percentage { get; set; } = 50; | ||
| [Parameter] public int Height { get; set; } = 2; | ||
| [Parameter] public string BackgroundClass { get; set; } = "bg-gray-100 rounded"; | ||
| [Parameter] public string? BackgroundClass { get; set; } = "bg-gray-100 rounded"; | ||
|
|
||
| private int _percentage = 50; | ||
|
|
||
| protected override void OnInitialized() { | ||
| _percentage = Percentage > 100 ? 100 : Percentage < 0 ? 0 : Percentage; | ||
| StateHasChanged(); | ||
| protected override void OnParametersSet() | ||
| { | ||
| _percentage = Math.Clamp(Percentage, 0, 100); | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching the project to
net9.0replaced theMicrosoft.AspNetCore.Components.Webpackage with aFrameworkReferencetoMicrosoft.AspNetCore.App. Framework references are only valid for server-hosted components and aren’t supported when the library is referenced from anet9.0-browseror Blazor WebAssembly project. Because Auto render mode needs to load the same component assembly in both server and browser contexts, this change prevents the package from being consumed by the client half of an Auto app and breaks the commit’s stated goal. Consider keeping the package reference or multi-targeting so the browser build doesn’t transitively depend onMicrosoft.AspNetCore.App.Useful? React with 👍 / 👎.