Skip to content

Conversation

@TaylorWatson
Copy link
Member

Summary

  • retarget the Razor class library to .NET 9 with nullable reference types, implicit usings, and a framework reference to Microsoft.AspNetCore.App
  • update the progress bar component to clamp percentage updates during parameter changes and handle optional CSS classes safely for server or client rendering
  • document the Blazor Auto render mode compatibility in the README

Testing

  • Not run (dotnet CLI is unavailable in the execution environment)

https://chatgpt.com/codex/tasks/task_e_68e72898bd18833288e0080996cf759b

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +28 to +30
<ItemGroup>
<SupportedPlatform Include="browser" />
<FrameworkReference Include="Microsoft.AspNetCore.App" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid framework reference that breaks WASM consumers

Auto render mode relies on this Razor class library being referenceable from both server and WebAssembly projects. Replacing the package reference with <FrameworkReference Include="Microsoft.AspNetCore.App" /> makes the library depend on the ASP.NET Core shared framework, which isn’t available when restoring or publishing a Blazor WebAssembly app. Any WASM (and therefore Auto mode) project that adds this package will now fail during restore with an unsupported framework error. Keep the project framework-agnostic (no explicit reference or a Microsoft.AspNetCore.Components.Web package) so it works for both environments.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant