HTM-1302: Integrate 3D functionality in Tailormap #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steinkobben
commented
Apr 24, 2024
•
steinkobben
commented
- Move Cesium code from MapService to OpenlayersMap
- Think about a way to add Terrains to Cesium (configurable ION token? hosted terrains? default no terrain?)
- Write additional functions to manage 3D layers
- Update checks for layer trees in admin-applications for 3D layers
- Check which function in viewer work or not when viewing in 3D
- Think about how to improve performance
- Use authorization for 3D Tileset services
# Conflicts: # projects/map/src/lib/models/layer-manager.model.ts
mprins
changed the title
mprins
requested changes
Jan 31, 2025
There was a problem hiding this comment.
something is off in the deployment, seems to be an undefined problem with new backed deployed, seems to be working: https://snapshot.tailormap.nl/pull-request/617/cesium/nl/app/3d_utrecht
# Conflicts: # package-lock.json # projects/admin-core/src/lib/admin-core.module.ts # projects/admin-core/src/lib/catalog/catalog-base-tree/catalog-base-tree-node/catalog-base-tree-node.component.ts
… between applications
geertplaisier
requested changes
Feb 12, 2025
projects/admin-core/src/lib/application/application-form/application-form.component.ts
Outdated
Show resolved
Hide resolved
...pplication-layer-tree/application-layer-tree-node/application-layer-tree-node.component.html
Outdated
Show resolved
Hide resolved
projects/admin-core/src/lib/application/helpers/application-tree.helper.ts
Outdated
Show resolved
Hide resolved
projects/admin-core/src/lib/catalog/geo-service-form/geo-service-form.component.ts
Show resolved
Hide resolved
projects/core/src/lib/components/feature-info/feature-info/feature-info.component.ts
Outdated
Show resolved
Hide resolved
projects/core/src/lib/components/feature-info/feature-info/feature-info.component.ts
Outdated
Show resolved
Hide resolved
projects/core/src/lib/components/feature-info/feature-info/feature-info.component.ts
Outdated
Show resolved
Hide resolved
geertplaisier
requested changes
Feb 13, 2025
| @@ -52,6 +52,9 @@ export class TreeComponent implements OnInit, OnDestroy { | |||
| @Input() | |||
| public dragHandleSelector?: string; | |||
|
|
|||
| @Input() | |||
| public singleLayerChecked = false; | |||
There was a problem hiding this comment.
Check if this can be removed if you use useRadioInputs instead
geertplaisier
requested changes
Feb 14, 2025
| this.componentRegistrationService.getRegisteredComponents$(this.area), | ||
| this.store$.select(selectIn3DView), | ||
| ]).pipe( | ||
| map(([ components, in3D ]) => { |
There was a problem hiding this comment.
Don't think this will ever happen. These base components are not registered through the ComponentRegistrationService so I think this can be removed. Maybe you want to let other (external) components register whether they could run in 3d or not, then that should be filtered. But for base components this is not needed I suspect.
projects/core/src/lib/components/toolbar/switch3D/switch3-d.component.spec.ts
Show resolved
Hide resolved
projects/core/src/lib/components/toolbar/switch3D/switch3-d.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.