Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cesium #617

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from
Draft

Cesium #617

wants to merge 38 commits into from

Conversation

steinkobben
Copy link
Contributor

@steinkobben steinkobben commented Apr 24, 2024

  • Move Cesium code from MapService to OpenlayersMap
  • Merge CesiumLayerManager into OpenLayersLayerManager?
  • Think about a way to add Terrains to Cesium (configurable ION token? hosted terrains? default no terrain?)
  • Write additional functions to manage 3D layers
  • Update checks for layer trees in admin-applications for 3D layers
  • Check which function in viewer work or not when viewing in 3D
  • Think about how to improve performance

Copy link

github-actions bot commented Apr 24, 2024

Test Results

  1 files  ±0  196 suites  +1   8m 27s ⏱️ -11s
484 tests +2  484 ✅ +2  0 💤 ±0  0 ❌ ±0 
564 runs  +3  564 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 44452f1. ± Comparison against base commit 0e35982.

♻️ This comment has been updated with latest results.

@mprins mprins added the enhancement New feature or request label Jun 25, 2024
@github-actions github-actions bot added the Stale This has not been worked on label Aug 26, 2024
@github-actions github-actions bot removed the Stale This has not been worked on label Sep 2, 2024
Copy link

codecov bot commented Sep 18, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
487 2 485 0
View the top 2 failed tests by shortest run time
CoordinateLinkWindowComponent should render button and open window on map click CoordinateLinkWindowComponent should render button and open window on map click
Stack Traces | 0.042s run time
Error: expect(received).toBeInTheDocument()

received value must be an HTMLElement or an SVGElement.
Received has value: null
    at __EXTERNAL_MATCHER_TRAP__ (.../expect/build/index.js:325:30)
    at Object.throwingMatcher [as toBeInTheDocument] (.../expect/build/index.js:326:15)
    at .../toolbar/coordinate-link-window/coordinate-link-window.component.spec.ts:73:48
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
ScaleBarComponent should render ScaleBarComponent should render
Stack Traces | 0.37s run time
Error: expect(jest.fn()).toHaveBeenCalled()

Expected number of calls: >= 1
Received number of calls:    0
    at .../toolbar/scale-bar/scale-bar.component.spec.ts:25:32
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

…hen those components are active:

- clicked-coordinates
- coordinate-link-window
- mouse-coordinates
- scale-bar
- streetview
…s-renderer.component.ts instead of within components.
# Conflicts:
#	package-lock.json
#	package.json
#	projects/shared/src/lib/helpers/index.ts
* updated to ol-cesium 2.22.0 and ol 10.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants