Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved playground #35

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Improved playground #35

merged 2 commits into from
Nov 27, 2024

Conversation

JulienTexier
Copy link
Collaborator

✨ What has changed?

This PR adds Image to the playground and improves the ProgressBar component.

It also fixes ajv related build errors by adding to devDependencies and downgrading eslint-plugin-lodash that was causing ajv version conflicts.

Copy link

Hi! 👋

To ensure a smooth review process, it is recommended to trigger a build (or an update if no native changes have been made since the last build).

You can do so by applying the appropriate label based on your needs:

• 🏗️ 🍏 iOS Build: Select eas-build-ios:dev to trigger a build for iOS
• 🏗️ 🤖 Android Build: Select eas-build-android:dev to trigger a build for Android
• 🏗️ 📲 All Platforms Build: Select eas-build-all:dev to trigger builds for both platforms
• 🌐 EAS Update: Select eas-update to trigger an update (automatically for both platforms)

Note

The update is managed by a custom GitHub action, while the build actions are handled directly via EAS integration.

Once you apply the respective label, the appropriate workflow will be triggered automatically. You can monitor the progress in the Actions tab.

Warning

If you push new commits to your PR branch after selecting a build label, a new build will be triggered automatically.

It is advisable to remove the label once applied and reapply it if necessary; you will likely need to trigger an update instead of a fresh build.

Important

After merging changes into the dev branch, a build will automatically be triggered for both platform using the dev profile.

Therefore, there is no need to manually initiate a build after merging to the dev branch.

Additionally, builds will automatically trigger when promoting changes to dev, test and prod.

For the prod branch, the build will also be automatically submitted to the app stores.

For more information, refer to the PR Reviews Guide.

@github-actions github-actions bot added the maintenance A label for routine maintenance tasks that do not affect user-facing functionality label Nov 27, 2024
@JulienTexier JulienTexier merged commit c0aed1e into dev Nov 27, 2024
3 checks passed
@JulienTexier JulienTexier deleted the chore/improved-playground branch November 27, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance A label for routine maintenance tasks that do not affect user-facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant