Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
Opening this PR to showcase a bit my knowledge regarding QA/Test Automation/CI.
For anyone that doesn't know me, i have been a Talisman sentinel for a long time and since the beginning of the last year shifted to QA/IT once again in my career. I have a background in IT, it is where I've started my career a long time ago(C++, PHP, delphi, networks, html, css, tech support), but then, later on i shifted to the construction area(Architecture) and now, returning, learning typescript and loving it(objects, classes, namespaces, generics, decorators).
Here's what my PR covers:
Playwright installation and basic configuration. (I've setup the installation inside the config folder)
Tailored a playwright fixture to install the built wallet on a chromium browser and wrote a simple on-boarding test that creates a Ethereum account.
Created a playwright.yml file that installs pnpm, install dependencies, build the wallet, install a playwright browser and execute the tests inside a predefined e2e folder.
The test uses the browser context instead of the page context and makes it possible to open a tab and use the extension. (The test itself takes 15-17s to run, what took most of the CI time was building the wallet itself ~3m)
link to workflow running on my fork: https://github.com/prury/talisman/actions/runs/10601904208/job/29382757340?pr=1
Future tests can be setup to run on the embed version of the extension, making it possible test every user interaction:
Previous PRs: https://github.com/kodadot/nft-gallery/pulls?page=2&q=is%3Apr+is%3Aclosed+author%3Aprury
Issues(245 closed): https://github.com/kodadot/nft-gallery/issues/created_by/prury