Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't throw error when currentEra is greater than 0, less than maxErasToCheck #1802

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

alecdwm
Copy link
Member

@alecdwm alecdwm commented Feb 7, 2025

The code here would check e.g. eras [-10, -9, -8, -7, -6, -5, -4, -3, -2, -1, 0, 1, 2, 3, 4, 5] if currentEra is 6.

Attempting to make calls to the chain with an era parameter less than 0 will throw errors.

Now, we'll filter for negative values, making the list of eras to check just [0, 1, 2, 3, 4, 5] if currentEra is 6.

@alecdwm alecdwm requested a review from 0xKheops February 7, 2025 04:14
@alecdwm alecdwm enabled auto-merge (squash) February 7, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant