-
-
Notifications
You must be signed in to change notification settings - Fork 546
fix(form-core): validate fields without components when setFieldValue… #1873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(form-core): validate fields without components when setFieldValue… #1873
Conversation
… is called - Fix validateField to run form-level validation for fields without field instances - Add test cases to verify validation works for fields without components - Resolves issue where setFieldValue didn't trigger validation for fields without <form.Field> components Fixes: Form validation not working for fields without associated components
|
|
View your CI Pipeline Execution ↗ for commit 96f6d69
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1873 +/- ##
==========================================
- Coverage 90.35% 90.24% -0.12%
==========================================
Files 38 41 +3
Lines 1752 1855 +103
Branches 444 469 +25
==========================================
+ Hits 1583 1674 +91
- Misses 149 162 +13
+ Partials 20 19 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… is called
Fixes: Form validation not working for fields without associated components
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact