Skip to content

Conversation

@techcodie
Copy link

… is called

  • Fix validateField to run form-level validation for fields without field instances
  • Add test cases to verify validation works for fields without components
  • Resolves issue where setFieldValue didn't trigger validation for fields without <form.Field> components

Fixes: Form validation not working for fields without associated components

🎯 Changes

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

… is called

- Fix validateField to run form-level validation for fields without field instances
- Add test cases to verify validation works for fields without components
- Resolves issue where setFieldValue didn't trigger validation for fields without <form.Field> components

Fixes: Form validation not working for fields without associated components
@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

⚠️ No Changeset found

Latest commit: 96f6d69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Nov 25, 2025

View your CI Pipeline Execution ↗ for commit 96f6d69

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 21s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 32s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-25 08:12:58 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 25, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1873

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1873

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1873

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1873

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1873

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1873

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@1873

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@1873

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@1873

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1873

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@1873

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1873

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1873

commit: 96f6d69

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (6892ed0) to head (96f6d69).
⚠️ Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1873      +/-   ##
==========================================
- Coverage   90.35%   90.24%   -0.12%     
==========================================
  Files          38       41       +3     
  Lines        1752     1855     +103     
  Branches      444      469      +25     
==========================================
+ Hits         1583     1674      +91     
- Misses        149      162      +13     
+ Partials       20       19       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant