Skip to content

test(react-query/useSuspenseQuery): remove unnecessary 'act' from background refetch, 'refetchInterval', and post-unmount assertions #10212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sukvvon wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

test(react-query/useSuspenseQuery): remove unnecessary 'act' from background refetch, 'refetchInterval', and post-unmount assertions #10212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-query/src/__tests__/useSuspenseQuery.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ describe('useSuspenseQuery', () => {

fireEvent.click(rendered.getByLabelText('toggle'))
expect(rendered.queryByText('loading')).not.toBeInTheDocument()
await act(() => vi.advanceTimersByTimeAsync(10))
await vi.advanceTimersByTimeAsync(10)
expect(rendered.queryByText('rendered')).not.toBeInTheDocument()
expect(queryCache.find({ queryKey: key })?.getObserversCount()).toBe(0)
})
Expand Down Expand Up @@ -811,7 +811,7 @@ describe('useSuspenseQuery', () => {
// refetch
fireEvent.click(rendered.getByRole('button', { name: 'refetch' }))
// we are now in error state but still have data to show
await act(() => vi.advanceTimersByTimeAsync(11))
await vi.advanceTimersByTimeAsync(11)
expect(rendered.getByText('rendered data error')).toBeInTheDocument()

consoleMock.mockRestore()
Expand Down Expand Up @@ -922,9 +922,9 @@ describe('useSuspenseQuery', () => {
expect(rendered.getByText('loading')).toBeInTheDocument()
await act(() => vi.advanceTimersByTimeAsync(10))
expect(rendered.getByText('count: 1')).toBeInTheDocument()
await act(() => vi.advanceTimersByTimeAsync(21))
await vi.advanceTimersByTimeAsync(21)
expect(rendered.getByText('count: 2')).toBeInTheDocument()
await act(() => vi.advanceTimersByTimeAsync(21))
await vi.advanceTimersByTimeAsync(21)
expect(rendered.getByText('count: 3')).toBeInTheDocument()

expect(count).toBeGreaterThanOrEqual(3)
Expand Down
Loading