Skip to content

fix: Update route file name in routing concepts#6807

Open
chapman-cc wants to merge 1 commit intoTanStack:mainfrom
chapman-cc:fix-typing-concepts-title
Open

fix: Update route file name in routing concepts#6807
chapman-cc wants to merge 1 commit intoTanStack:mainfrom
chapman-cc:fix-typing-concepts-title

Conversation

@chapman-cc
Copy link

@chapman-cc chapman-cc commented Mar 3, 2026

The code block title src/routes/posts.tsx does not match against the line above posts.$postId.tsx

This pr fixes this typo

Summary by CodeRabbit

  • Documentation
    • Updated routing guides with improved code examples that more accurately demonstrate dynamic route segment naming conventions in real-world implementations.

The code block title `src/routes/posts.tsx` does not match against the line above `posts.$postId.tsx`

This pr fixes this typo
@github-actions github-actions bot added the documentation Everything documentation related label Mar 3, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3318878 and 1ab1f27.

📒 Files selected for processing (1)
  • docs/router/routing/routing-concepts.md

📝 Walkthrough

Walkthrough

This PR updates a code sample filename in the routing concepts documentation from src/routes/posts.tsx to src/routes/posts/$postId.tsx to accurately reflect the dynamic route structure being demonstrated.

Changes

Cohort / File(s) Summary
Documentation
docs/router/routing/routing-concepts.md
Updated React code sample filename from src/routes/posts.tsx to src/routes/posts/$postId.tsx to correctly represent the dynamic route structure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • docs: Fixed filenames #6675: Updates sample filenames/titles in router documentation to show dynamic segments and accurate file extensions.

Suggested reviewers

  • Insik-Han
  • SeanCassiere

Poem

🐰 A path, a name, now aligned at last,
Where $postId dances, not in the past,
The docs now gleam with clarity bright,
One little filename—set perfectly right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: updating a route file name (from posts.tsx to posts/$postId.tsx) in the routing concepts documentation to correct a mismatch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 3, 2026

View your CI Pipeline Execution ↗ for commit 1ab1f27

Command Status Duration Result
nx run @benchmarks/bundle-size:build --outputSt... ✅ Succeeded 1m 31s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-03 13:24:56 UTC

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Bundle Size Benchmarks

  • Commit: 33188782e179
  • Measured at: 2026-03-03T13:24:02.044Z
  • Baseline source: history:33188782e179
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 86.58 KiB 0 B (0.00%) 272.45 KiB 75.22 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-router.full 89.61 KiB 0 B (0.00%) 282.78 KiB 77.90 KiB ▅▅▅▅▅▅▅▅▅▅▅
solid-router.minimal 35.88 KiB 0 B (0.00%) 107.56 KiB 32.26 KiB ▅▅▅▅▅▅▅▅▅▅▅
solid-router.full 40.21 KiB 0 B (0.00%) 120.61 KiB 36.13 KiB ▅▅▅▅▅▅▅▅▅▅▅
vue-router.minimal 51.75 KiB 0 B (0.00%) 147.54 KiB 46.50 KiB ▅▅▅▅▅▅▅▅▅▅▅
vue-router.full 56.55 KiB 0 B (0.00%) 163.12 KiB 50.86 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-start.minimal 99.11 KiB 0 B (0.00%) 311.58 KiB 85.68 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-start.full 102.50 KiB 0 B (0.00%) 321.39 KiB 88.63 KiB ▁▁▁▁███████
solid-start.minimal 48.19 KiB 0 B (0.00%) 145.13 KiB 42.67 KiB ▅▅▅▅▅▅▅▅▅▅▅
solid-start.full 53.68 KiB 0 B (0.00%) 161.08 KiB 47.37 KiB ▁▁▁▁███████

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Everything documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant