Skip to content

chore: ensure no nx cloud is used for benchmark#6817

Merged
beaussan merged 6 commits intomainfrom
fix-comment-ci
Mar 4, 2026
Merged

chore: ensure no nx cloud is used for benchmark#6817
beaussan merged 6 commits intomainfrom
fix-comment-ci

Conversation

@beaussan
Copy link
Contributor

@beaussan beaussan commented Mar 3, 2026

Merging this to test it again main in a different branch

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configurations to optimize build processes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2217f7c and 095475b.

📒 Files selected for processing (2)
  • .github/workflows/bundle-size.yml
  • .github/workflows/client-nav-benchmarks.yml

📝 Walkthrough

Walkthrough

Two GitHub Actions workflows were updated to add an environment variable NX_NO_CLOUD: true at the workflow level, disabling NX Cloud features during CI runs. Additionally, a minor formatting adjustment was made to remove an empty line in one workflow.

Changes

Cohort / File(s) Summary
NX Cloud Disabled in CI Workflows
.github/workflows/bundle-size.yml, .github/workflows/client-nav-benchmarks.yml
Added NX_NO_CLOUD: true environment variable to disable NX Cloud during CI execution. Also removed an empty line formatting in bundle-size workflow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The clouds must rest, we say with cheer,
NX Cloud's disabled far and near!
Our workflows run so swift and clean,
No cloud delays will intervene!
✨ Benchmarks bound with freedom bright,
GitHub Actions take their flight!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-comment-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 3, 2026

View your CI Pipeline Execution ↗ for commit 095475b

Command Status Duration Result
nx run @benchmarks/bundle-size:build --outputSt... ✅ Succeeded 1m 27s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-03 23:51:27 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 3, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6817

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6817

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6817

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6817

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6817

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6817

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6817

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6817

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6817

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6817

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6817

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6817

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6817

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6817

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6817

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6817

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6817

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6817

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6817

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6817

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6817

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6817

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6817

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6817

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6817

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6817

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6817

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6817

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6817

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6817

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6817

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6817

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6817

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6817

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6817

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6817

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6817

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6817

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6817

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6817

commit: 2d3f390

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Bundle Size Benchmarks

  • Commit: 7083bcbecbf5
  • Measured at: 2026-03-03T23:49:56.145Z
  • Baseline source: history:2217f7c3f19f
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 86.58 KiB 0 B (0.00%) 272.45 KiB 75.22 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-router.full 89.61 KiB 0 B (0.00%) 282.78 KiB 77.90 KiB ▅▅▅▅▅▅▅▅▅▅▅
solid-router.minimal 35.88 KiB 0 B (0.00%) 107.56 KiB 32.26 KiB ▅▅▅▅▅▅▅▅▅▅▅
solid-router.full 40.21 KiB 0 B (0.00%) 120.61 KiB 36.13 KiB ▅▅▅▅▅▅▅▅▅▅▅
vue-router.minimal 51.75 KiB 0 B (0.00%) 147.54 KiB 46.50 KiB ▅▅▅▅▅▅▅▅▅▅▅
vue-router.full 56.55 KiB 0 B (0.00%) 163.12 KiB 50.86 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-start.minimal 99.11 KiB 0 B (0.00%) 311.58 KiB 85.68 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-start.full 102.50 KiB 0 B (0.00%) 321.39 KiB 88.63 KiB ▁▁█████████
solid-start.minimal 48.19 KiB 0 B (0.00%) 145.13 KiB 42.67 KiB ▅▅▅▅▅▅▅▅▅▅▅
solid-start.full 53.68 KiB 0 B (0.00%) 161.08 KiB 47.37 KiB ▁▁█████████

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2026

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing fix-comment-ci (095475b) with main (7083bcb)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@beaussan beaussan marked this pull request as ready for review March 4, 2026 00:01
@beaussan beaussan merged commit 9f35318 into main Mar 4, 2026
8 of 9 checks passed
@beaussan beaussan deleted the fix-comment-ci branch March 4, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant