refactor: signals implementation without dual store subscriptions by Sheraff · Pull Request #6819 · TanStack/router

Sheraff · 2026-03-04T16:27:39Z

No description provided.

coderabbitai · 2026-03-04T16:27:51Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bed3b1dc-6cd6-4a26-a827-c00a6a339fe6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch refactor-signals-remove-dual-store-subscriptions

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-03-04T16:28:11Z

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

_{To disable these notifications, a workspace admin can disable them in workspace settings.}

View your CI Pipeline Execution ↗ for commit a06a3d9

Command	Status	Duration	Result
`nx run @benchmarks/client-nav:test:perf:solid`	❌ Failed	1m 11s	View ↗
`nx run @benchmarks/ssr:test:perf:vue`	✅ Succeeded	2m 13s	View ↗
`nx run @benchmarks/ssr:test:perf:solid`	✅ Succeeded	1m 48s	View ↗
`nx run @benchmarks/ssr:test:perf:react`	✅ Succeeded	1m 56s	View ↗
`nx run @benchmarks/client-nav:test:perf:vue`	✅ Succeeded	1m 18s	View ↗
`nx run @benchmarks/client-nav:test:perf:react`	✅ Succeeded	1m 17s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-04 21:34:34 UTC

github-actions · 2026-03-04T16:30:30Z

Bundle Size Benchmarks

Commit: 861f319bbeb8
Measured at: 2026-03-04T21:20:56.809Z
Baseline source: history:9c81d5ac571e
Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Raw	Brotli	Trend
`react-router.minimal`	87.50 KiB	+673 B (+0.76%)	275.62 KiB	76.04 KiB	▁▁▁▁▁▁▁▁▁▁▃█
`react-router.full`	90.73 KiB	+865 B (+0.94%)	286.31 KiB	78.73 KiB	▁▁▁▁▁▁▁▁▁▁▃█
`solid-router.minimal`	34.83 KiB	-1.34 KiB (-3.71%)	105.25 KiB	31.22 KiB	▆▆▆▆▆▆▆▆▆▆█▁
`solid-router.full`	39.47 KiB	-1.03 KiB (-2.54%)	119.49 KiB	35.34 KiB	▆▆▆▆▆▆▆▆▆▆█▁
`vue-router.minimal`	52.75 KiB	+732 B (+1.37%)	151.06 KiB	47.33 KiB	▁▁▁▁▁▁▁▁▁▁▃█
`vue-router.full`	57.82 KiB	+999 B (+1.72%)	167.13 KiB	51.61 KiB	▁▁▁▁▁▁▁▁▁▁▃█
`react-start.minimal`	100.16 KiB	+777 B (+0.76%)	314.79 KiB	86.52 KiB	▁▁▁▁▁▁▁▁▁▁▃█
`react-start.full`	103.51 KiB	+743 B (+0.71%)	324.96 KiB	89.45 KiB	▁▁▁▁▁▁▁▁▁▁▃█
`solid-start.minimal`	47.17 KiB	-1.33 KiB (-2.74%)	142.86 KiB	41.62 KiB	▆▆▆▆▆▆▆▆▆▆█▁
`solid-start.full`	52.89 KiB	-1.07 KiB (-1.99%)	159.99 KiB	46.59 KiB	▆▆▆▆▆▆▆▆▆▆█▁

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

pkg-pr-new · 2026-03-04T16:31:59Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6819

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6819

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6819

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6819

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6819

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6819

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6819

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6819

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6819

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6819

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6819

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6819

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6819

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6819

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6819

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6819

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6819

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6819

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6819

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6819

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6819

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6819

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6819

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6819

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6819

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6819

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6819

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6819

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6819

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6819

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6819

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6819

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6819

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6819

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6819

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6819

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6819

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6819

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6819

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6819

commit: 551610a

codspeed-hq · 2026-03-04T16:48:57Z

Merging this PR will improve performance by 27.87%

⚡ 2 improved benchmarks
✅ 3 untouched benchmarks

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`ssr request loop (vue)`	749.4 ms	642.9 ms	+16.57%
⚡	`client-side navigation loop (vue)`	55.7 ms	43.5 ms	+27.87%

_{Comparing refactor-signals-remove-dual-store-subscriptions (a06a3d9) with codex/solid-native-router-stores (ca38dfe)}

refactor: signals implementation without dual store subscriptions

8085591

github-actions bot added package: react-router package: router-core package: solid-router package: vue-router labels Mar 4, 2026

Sheraff and others added 6 commits March 4, 2026 18:46

more vue refactoring using signals instead of black magic

468da49

same but for solid

c0b2de0

minor simplification of react-router

821815e

minor cleanup

64ac07e

ci: apply automated fixes

00538cb

fix onRendered

a06a3d9

Sheraff merged commit a6b9bf0 into codex/solid-native-router-stores Mar 4, 2026
6 of 7 checks passed

Sheraff deleted the refactor-signals-remove-dual-store-subscriptions branch March 4, 2026 21:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: signals implementation without dual store subscriptions#6819

refactor: signals implementation without dual store subscriptions#6819
Sheraff merged 7 commits intocodex/solid-native-router-storesfrom
refactor-signals-remove-dual-store-subscriptions

Sheraff commented Mar 4, 2026

Uh oh!

coderabbitai bot commented Mar 4, 2026 •

edited

Loading

Review skipped

Uh oh!

nx-cloud bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Sheraff commented Mar 4, 2026

Uh oh!

coderabbitai bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

nx-cloud bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Nx Cloud AI Fix Eligible

Uh oh!

github-actions bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Benchmarks

Uh oh!

pkg-pr-new bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 27.87%

Performance Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai bot commented Mar 4, 2026 •

edited

Loading

nx-cloud bot commented Mar 4, 2026 •

edited

Loading

github-actions bot commented Mar 4, 2026 •

edited

Loading

pkg-pr-new bot commented Mar 4, 2026 •

edited

Loading

codspeed-hq bot commented Mar 4, 2026 •

edited

Loading