fix(virtual-core): loosen approxEqual to allow 1px difference #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e538844 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit e538844.
☁️ Nx Cloud last updated this comment at |
Merged
ogonkov
reviewed
May 5, 2025
|
|
||
| if (!approxEqual(latestOffset, this.getScrollOffset())) { | ||
| const currentScrollOffset = this.getScrollOffset() | ||
| if (!approxEqual(latestOffset, currentScrollOffset)) { |
There was a problem hiding this comment.
Looks like there still a chance to get infinite loop
Collaborator
Author
There was a problem hiding this comment.
Do you have something specific in mind?
There was a problem hiding this comment.
I guess for any given scrollToIndex we want to set some kind of counter, and break recursion when this counter is reach some limit, kinda dead loop detector
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #980