Skip to content

Commit 23d9705

Browse files
joowojrjoowojr
committed
CLAP-334 Docs: 매개변수 final 선언
- #426
1 parent b24a41c commit 23d9705

11 files changed

+62
-71
lines changed

‎src/main/java/clap/server/adapter/outbound/infrastructure/s3/S3UploadAdapter.java‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ public class S3UploadAdapter implements S3UploadPort {
2626
private final KakaoS3Config kakaoS3Config;
2727
private final S3Client s3Client;
2828

29-
public List<String> uploadFiles(FilePathPolicyConstants filePrefix, List<MultipartFile> multipartFiles) {
29+
public List<String> uploadFiles(final FilePathPolicyConstants filePrefix,final List<MultipartFile> multipartFiles) {
3030
return multipartFiles.stream().map((file) -> uploadSingleFile(filePrefix, file)).toList();
3131
}
3232

33-
public String uploadSingleFile(FilePathPolicyConstants filePrefix, MultipartFile file) {
33+
public String uploadSingleFile(final FilePathPolicyConstants filePrefix,final MultipartFile file) {
3434
try {
3535
Path filePath = getFilePath(file);
3636
String objectKey = createObjectKey(filePrefix.getPath(), file.getOriginalFilename());
@@ -43,17 +43,17 @@ public String uploadSingleFile(FilePathPolicyConstants filePrefix, MultipartFile
4343
}
4444
}
4545

46-
private String getFileUrl(String objectKey) {
46+
private String getFileUrl(final String objectKey) {
4747
return kakaoS3Config.getEndpoint() + "/v1/" + kakaoS3Config.getProjectId() + '/' + kakaoS3Config.getBucketName() + '/' + objectKey;
4848
}
4949

50-
private static Path getFilePath(MultipartFile file) throws IOException {
50+
private static Path getFilePath(final MultipartFile file) throws IOException {
5151
Path path = Files.createTempFile(null,null);
5252
Files.copy(file.getInputStream(),path, StandardCopyOption.REPLACE_EXISTING);
5353
return path;
5454
}
5555

56-
private void uploadToS3(String filePath, Path path) {
56+
private void uploadToS3(final String filePath,final Path path) {
5757
PutObjectRequest putObjectRequest = PutObjectRequest.builder()
5858
.bucket(kakaoS3Config.getBucketName())
5959
.key(filePath)
@@ -62,7 +62,7 @@ private void uploadToS3(String filePath, Path path) {
6262
s3Client.putObject(putObjectRequest, path);
6363
}
6464

65-
private String createObjectKey(String filepath, String fileName) {
65+
private String createObjectKey(final String filepath,final String fileName) {
6666
String fileId = FileIDGenerator.createFileId();
6767
return String.format("%s/%s-%s", filepath, fileId, fileName);
6868
}

‎src/main/java/clap/server/adapter/outbound/infrastructure/sse/SseAdapter.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ public class SseAdapter implements CommandSsePort {
1313
private final EmitterRepository emitterRepository;
1414

1515
@Override
16-
public void save(Long receiverId, SseEmitter emitter) {
16+
public void save(final Long receiverId,final SseEmitter emitter) {
1717
emitterRepository.save(receiverId, emitter);
1818
}
1919

2020
@Override
21-
public void delete(Long receiverId) {
21+
public void delete(final Long receiverId) {
2222
emitterRepository.delete(receiverId);
2323
}
2424
}

‎src/main/java/clap/server/adapter/outbound/persistense/ApiLogPersistenceAdapter.java‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package clap.server.adapter.outbound.persistense;
22

33
import clap.server.adapter.inbound.web.dto.log.request.FilterLogRequest;
4-
54
import clap.server.adapter.outbound.persistense.mapper.ApiLogPersistenceMapper;
65
import clap.server.adapter.outbound.persistense.mapper.MemberPersistenceMapper;
76
import clap.server.adapter.outbound.persistense.repository.log.AnonymousLogRepository;
@@ -12,7 +11,6 @@
1211
import clap.server.common.annotation.architecture.PersistenceAdapter;
1312
import clap.server.domain.model.log.AnonymousLog;
1413
import clap.server.domain.model.log.MemberLog;
15-
1614
import lombok.RequiredArgsConstructor;
1715
import org.springframework.data.domain.Page;
1816
import org.springframework.data.domain.Pageable;
@@ -31,25 +29,25 @@ public class ApiLogPersistenceAdapter implements CommandLogPort, LoadLogPort {
3129

3230
@Transactional
3331
@Override
34-
public void saveMemberLog(MemberLog memberLog) {
32+
public void saveMemberLog(final MemberLog memberLog) {
3533
apiLogRepository.save(apiLogPersistenceMapper.mapMemberLogToEntity(memberLog, memberPersistenceMapper.toEntity(memberLog.getMember())));
3634

3735
}
3836

3937
@Override
40-
public void saveAnonymousLog(AnonymousLog anonymousLog) {
38+
public void saveAnonymousLog(final AnonymousLog anonymousLog) {
4139
apiLogRepository.save(apiLogPersistenceMapper.mapAnonymousLogToEntity(anonymousLog, anonymousLog.getLoginNickname()));
4240
}
4341

4442

4543
@Override
46-
public Page<MemberLog> filterMemberLogs(FilterLogRequest memberLogRequest, Pageable pageable, String sortDirection) {
44+
public Page<MemberLog> filterMemberLogs(final FilterLogRequest memberLogRequest, final Pageable pageable, final String sortDirection) {
4745
return memberLogRepository.filterMemberLogs(memberLogRequest, pageable, sortDirection)
4846
.map(apiLogPersistenceMapper::mapMemberLogEntityToDomain);
4947
}
5048

5149
@Override
52-
public Page<AnonymousLog> filterAnonymousLogs(FilterLogRequest anonymousLogRequest, Pageable pageable, String sortDirection) {
50+
public Page<AnonymousLog> filterAnonymousLogs(final FilterLogRequest anonymousLogRequest, final Pageable pageable, final String sortDirection) {
5351
return anonymousLogRepository.filterAnonymousLogs(anonymousLogRequest, pageable, sortDirection)
5452
.map(apiLogPersistenceMapper::mapAnonymousLogEntityToDomain);
5553
}

‎src/main/java/clap/server/adapter/outbound/persistense/AttachmentPersistenceAdapter.java‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import clap.server.application.port.outbound.task.LoadAttachmentPort;
88
import clap.server.common.annotation.architecture.PersistenceAdapter;
99
import clap.server.domain.model.task.Attachment;
10-
1110
import lombok.RequiredArgsConstructor;
1211

1312
import java.util.List;
@@ -24,13 +23,13 @@ public class AttachmentPersistenceAdapter implements CommandAttachmentPort, Load
2423

2524

2625
@Override
27-
public void save(Attachment attachment) {
26+
public void save(final Attachment attachment) {
2827
attachmentRepository.save(attachmentPersistenceMapper.toEntity(attachment));
2928
}
3029

3130

3231
@Override
33-
public void saveAll(List<Attachment> attachments) {
32+
public void saveAll(final List<Attachment> attachments) {
3433
List<AttachmentEntity> attachmentEntities = attachments.stream()
3534
.map(attachmentPersistenceMapper::toEntity)
3635
.collect(Collectors.toList());
@@ -54,7 +53,7 @@ public List<Attachment> findAllByTaskIdAndCommentIsNullAndAttachmentId(final Lon
5453
}
5554

5655
@Override
57-
public Optional<Attachment> findByCommentId(Long commentId) {
56+
public Optional<Attachment> findByCommentId(final Long commentId) {
5857
Optional<AttachmentEntity> attachmentEntity = attachmentRepository.findByComment_CommentId(commentId);
5958
return attachmentEntity.map(attachmentPersistenceMapper::toDomain);
6059
}
@@ -68,7 +67,7 @@ public List<Attachment> findAllByTaskIdAndCommentIsNotNull(final Long taskId) {
6867
}
6968

7069
@Override
71-
public boolean exitsByCommentId(Long commentId) {
70+
public boolean exitsByCommentId(final Long commentId) {
7271
return attachmentRepository.existsByComment_CommentId(commentId);
7372
}
7473
}

‎src/main/java/clap/server/adapter/outbound/persistense/CategoryPersistenceAdapter.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public class CategoryPersistenceAdapter implements LoadCategoryPort, CommandCate
2020
private final CategoryPersistenceMapper categoryPersistenceMapper;
2121

2222
@Override
23-
public Optional<Category> findById(Long id) {
23+
public Optional<Category> findById(final Long id) {
2424
Optional<CategoryEntity> categoryEntity = categoryRepository.findById(id);
2525
return categoryEntity.map(categoryPersistenceMapper::toDomain);
2626
}
@@ -50,7 +50,7 @@ public List<Category> findSubCategory() {
5050
}
5151

5252
@Override
53-
public void save(Category category) {
53+
public void save(final Category category) {
5454
categoryRepository.save(categoryPersistenceMapper.toEntity(category));
5555
}
5656
}

‎src/main/java/clap/server/adapter/outbound/persistense/CommentPersistenceAdapter.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,24 +19,24 @@ public class CommentPersistenceAdapter implements LoadCommentPort, CommandCommen
1919
private final CommentPersistenceMapper commentPersistenceMapper;
2020

2121
@Override
22-
public Optional<Comment> findById(Long commentId) {
22+
public Optional<Comment> findById(final Long commentId) {
2323
Optional<CommentEntity> commentEntity = commentRepository.findById(commentId);
2424
return commentEntity.map(commentPersistenceMapper::toDomain);
2525
}
2626

2727
@Override
28-
public Comment saveComment(Comment comment) {
28+
public Comment saveComment(final Comment comment) {
2929
CommentEntity commentEntity = commentRepository.save(commentPersistenceMapper.toEntity(comment));
3030
return commentPersistenceMapper.toDomain(commentEntity);
3131
}
3232

3333
@Override
34-
public void deleteCommentWithTaskHistory(Long commentId) {
34+
public void deleteCommentWithTaskHistory(final Long commentId) {
3535
commentRepository.deleteCommentWithTaskHistory(commentId);
3636
}
3737

3838
@Override
39-
public void deleteComment(Comment comment) {
39+
public void deleteComment(final Comment comment) {
4040
commentRepository.delete(commentPersistenceMapper.toEntity(comment));
4141
}
4242
}

‎src/main/java/clap/server/adapter/outbound/persistense/LabelPersistenceAdapter.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public class LabelPersistenceAdapter implements LoadLabelPort, CommandLabelPort
2121
private final LabelPersistenceMapper labelPersistenceMapper;
2222

2323
@Override
24-
public Optional<Label> findById(Long labelId) {
24+
public Optional<Label> findById(final Long labelId) {
2525
Optional<LabelEntity> labelEntity = labelRepository.findById(labelId);
2626
return labelEntity.map(labelPersistenceMapper::toDomain);
2727
}

‎src/main/java/clap/server/adapter/outbound/persistense/MemberPersistenceAdapter.java‎

Lines changed: 18 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -4,30 +4,28 @@
44
import clap.server.adapter.outbound.persistense.entity.member.MemberEntity;
55
import clap.server.adapter.outbound.persistense.entity.member.constant.MemberRole;
66
import clap.server.adapter.outbound.persistense.entity.member.constant.MemberStatus;
7+
import clap.server.adapter.outbound.persistense.entity.task.TaskEntity;
8+
import clap.server.adapter.outbound.persistense.entity.task.constant.TaskStatus;
79
import clap.server.adapter.outbound.persistense.mapper.MemberPersistenceMapper;
10+
import clap.server.adapter.outbound.persistense.mapper.TaskPersistenceMapper;
811
import clap.server.adapter.outbound.persistense.repository.member.MemberRepository;
12+
import clap.server.adapter.outbound.persistense.repository.task.TaskRepository;
913
import clap.server.application.port.outbound.member.CommandMemberPort;
1014
import clap.server.application.port.outbound.member.LoadMemberPort;
1115
import clap.server.common.annotation.architecture.PersistenceAdapter;
12-
import clap.server.domain.model.task.Task;
13-
import clap.server.adapter.outbound.persistense.entity.task.constant.TaskStatus ;
14-
import clap.server.adapter.outbound.persistense.entity.task.TaskEntity;
15-
import clap.server.adapter.outbound.persistense.repository.task.TaskRepository;
16-
import clap.server.adapter.outbound.persistense.mapper.TaskPersistenceMapper;
17-
import java.util.stream.Collectors;
18-
import java.util.List;
19-
2016
import clap.server.domain.model.member.Member;
21-
import com.querydsl.jpa.impl.JPAQueryFactory;
17+
import clap.server.domain.model.task.Task;
2218
import lombok.RequiredArgsConstructor;
2319
import org.springframework.data.domain.Page;
2420
import org.springframework.data.domain.Pageable;
2521

22+
import java.util.List;
2623
import java.util.Optional;
24+
import java.util.stream.Collectors;
2725

2826
@PersistenceAdapter
2927
@RequiredArgsConstructor
30-
public class MemberPersistenceAdapter implements LoadMemberPort, CommandMemberPort {
28+
public class MemberPersistenceAdapter implements LoadMemberPort, CommandMemberPort {
3129
private final MemberRepository memberRepository;
3230
private final MemberPersistenceMapper memberPersistenceMapper;
3331
private final TaskRepository taskRepository;
@@ -51,7 +49,6 @@ public Optional<Member> findByNickname(final String nickname) {
5149
return memberEntity.map(memberPersistenceMapper::toDomain);
5250
}
5351

54-
// 검토자인 담당자들 조회
5552
@Override
5653
public List<Member> findReviewers() {
5754
List<MemberEntity> memberEntities = memberRepository.findByIsReviewerTrue();
@@ -61,8 +58,8 @@ public List<Member> findReviewers() {
6158
}
6259

6360
@Override
64-
public Optional<Member> findReviewerById(Long id) {
65-
Optional<MemberEntity> memberEntity = memberRepository.findByMemberIdAndIsReviewerTrue(id);
61+
public Optional<Member> findReviewerById(final Long id) {
62+
Optional<MemberEntity> memberEntity = memberRepository.findByMemberIdAndIsReviewerTrue(id);
6663
return memberEntity.map(memberPersistenceMapper::toDomain);
6764
}
6865

@@ -73,7 +70,7 @@ public void save(final Member member) {
7370
}
7471

7572
@Override
76-
public void saveAll(List<Member> members) {
73+
public void saveAll(final List<Member> members) {
7774
List<MemberEntity> memberEntities = members.stream().map(memberPersistenceMapper::toEntity).toList();
7875
memberRepository.saveAll(memberEntities);
7976
}
@@ -87,35 +84,35 @@ public List<Member> findActiveManagers() {
8784
}
8885

8986
@Override
90-
public List<Task> findTasksByMemberIdAndStatus(Long memberId, List<TaskStatus> taskStatuses) {
87+
public List<Task> findTasksByMemberIdAndStatus(final Long memberId, final List<TaskStatus> taskStatuses) {
9188
List<TaskEntity> taskEntities = taskRepository.findByProcessor_MemberIdAndTaskStatusIn(memberId, taskStatuses);
9289
return taskEntities.stream()
9390
.map(taskPersistenceMapper::toDomain)
9491
.collect(Collectors.toList());
9592
}
9693

9794
@Override
98-
public Page<Member> findAllMembers(Pageable pageable) {
95+
public Page<Member> findAllMembers(final Pageable pageable) {
9996
return memberRepository.findAllMembers(pageable).map(memberPersistenceMapper::toDomain);
10097
}
10198

10299
@Override
103-
public Page<Member> findMembersWithFilter(Pageable pageable, FindMemberRequest filterRequest, String sortDirection) {
104-
return memberRepository.findMembersWithFilter(pageable, filterRequest,sortDirection).map(memberPersistenceMapper::toDomain);
100+
public Page<Member> findMembersWithFilter(final Pageable pageable, final FindMemberRequest filterRequest, final String sortDirection) {
101+
return memberRepository.findMembersWithFilter(pageable, filterRequest, sortDirection).map(memberPersistenceMapper::toDomain);
105102
}
106103

107104
@Override
108-
public Optional<Member> findByNicknameAndEmail(String nickname, String email) {
105+
public Optional<Member> findByNicknameAndEmail(final String nickname, final String email) {
109106
return memberRepository.findByNicknameAndEmail(nickname, email).map(memberPersistenceMapper::toDomain);
110107
}
111108

112109
@Override
113-
public Optional<Member> findByNameAndEmail(String name, String email) {
110+
public Optional<Member> findByNameAndEmail(final String name, final String email) {
114111
return memberRepository.findByNameAndEmail(name, email).map(memberPersistenceMapper::toDomain);
115112
}
116113

117114
@Override
118-
public Optional<Member> findByEmail(String email) {
115+
public Optional<Member> findByEmail(final String email) {
119116
return memberRepository.findByEmail(email)
120117
.map(memberPersistenceMapper::toDomain);
121118
}

‎src/main/java/clap/server/adapter/outbound/persistense/NotificationPersistenceAdapter.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,32 +23,32 @@ public class NotificationPersistenceAdapter implements LoadNotificationPort, Com
2323

2424

2525
@Override
26-
public Optional<Notification> findById(Long notificationId) {
26+
public Optional<Notification> findById(final Long notificationId) {
2727
return notificationRepository.findById(notificationId)
2828
.map(notificationPersistenceMapper::toDomain);
2929
}
3030

3131
@Override
32-
public Slice<Notification> findAllByReceiverId(Long receiverId, Pageable pageable) {
32+
public Slice<Notification> findAllByReceiverId(final Long receiverId, final Pageable pageable) {
3333
return notificationRepository
3434
.findAllByReceiver_MemberIdOrderByCreatedAtDesc(receiverId, pageable)
3535
.map(notificationPersistenceMapper::toDomain);
3636
}
3737

3838
@Override
39-
public List<Notification> findNotificationsByMemberId(Long memberId) {
39+
public List<Notification> findNotificationsByMemberId(final Long memberId) {
4040
return notificationRepository.findAllByReceiver_MemberId(memberId)
4141
.stream().map(notificationPersistenceMapper::toDomain)
4242
.collect(Collectors.toList());
4343
}
4444

4545
@Override
46-
public Integer countNotification(Long memberId) {
46+
public Integer countNotification(final Long memberId) {
4747
return notificationRepository.countByIsReadFalseAndReceiver_MemberId(memberId);
4848
}
4949

5050
@Override
51-
public void save(Notification notification) {
51+
public void save(final Notification notification) {
5252
notificationRepository.save(notificationPersistenceMapper.toEntity(notification));
5353
}
5454
}

‎src/main/java/clap/server/adapter/outbound/persistense/TaskHistoryPersistenceAdapter.java‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
import clap.server.application.port.outbound.taskhistory.CommandTaskHistoryPort;
88
import clap.server.application.port.outbound.taskhistory.LoadTaskHistoryPort;
99
import clap.server.common.annotation.architecture.PersistenceAdapter;
10-
11-
1210
import clap.server.domain.model.task.TaskHistory;
1311
import lombok.RequiredArgsConstructor;
1412

@@ -22,22 +20,22 @@ public class TaskHistoryPersistenceAdapter implements LoadTaskHistoryPort, Comma
2220
private final TaskHistoryPersistenceMapper taskHistoryPersistenceMapper;
2321

2422
@Override
25-
public List<TaskHistory> findAllTaskHistoriesByTaskId(Long taskId) {
23+
public List<TaskHistory> findAllTaskHistoriesByTaskId(final Long taskId) {
2624
return taskHistoryRepository.findAllTaskHistoriesByTaskId(taskId)
2725
.stream()
2826
.map(taskHistoryPersistenceMapper::toDomain)
2927
.toList();
3028
}
3129

3230
@Override
33-
public TaskHistory save(TaskHistory taskHistory) {
31+
public TaskHistory save(final TaskHistory taskHistory) {
3432
TaskHistoryEntity taskHistoryEntity = taskHistoryPersistenceMapper.toEntity(taskHistory);
3533
TaskHistoryEntity savedTaskHistoryEntity = taskHistoryRepository.save(taskHistoryEntity);
3634
return taskHistoryPersistenceMapper.toDomain(savedTaskHistoryEntity);
3735
}
3836

3937
@Override
40-
public void deleteTaskHistoryByCommentId(Long commentId) {
38+
public void deleteTaskHistoryByCommentId(final Long commentId) {
4139
taskHistoryRepository.updateByComment_CommentId(commentId);
4240
}
4341
}

0 commit comments

Comments
 (0)