This repository was archived by the owner on Oct 2, 2025. It is now read-only.
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the TaskRatchet SDK dependency from version 6.0.1 to 7.0.0 to resolve an issue with stale Clerk auth tokens in the web application.
- Updates SDK dependency to leverage new authentication token handling mechanism
- Refactors authentication token management to use a getter pattern instead of direct token setting
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates @taskratchet/sdk dependency from ^6.0.1 to ^7.0.0 |
| src/components/organisms/NavBar.tsx | Refactors auth token handling to use setAuthTokenGetter with async callback pattern |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
narthur
temporarily deployed
to
sdk-update - tr-web PR #179
Render
Destroyed
Contributor
WalkthroughUpdated @taskratchet/sdk dependency to ^7.0.0 and refactored NavBar to use setAuthTokenGetter with an async token retrieval function instead of directly setting tokens. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Outdated dependencies |
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/components/organisms/NavBar.tsx (1)
37-42: Prevent token staleness by skipping Clerk cache in the getter.To further reduce stale-token risk, fetch a fresh token each time:
Apply:
- return (await clerk.session?.getToken()) ?? null; + return (await clerk.session?.getToken({ skipCache: true })) ?? null;Also consider moving the
setAuthTokenGetterregistration to the top-level app layout/provider if any SDK calls could occur before NavBar mounts, ensuring the getter is available ASAP.
📜 Review details
Configuration used: Repository: TaskRatchet/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
package.json(1 hunks)src/components/organisms/NavBar.tsx(2 hunks)
🔇 Additional comments (2)
package.json (1)
28-28: SDK v7 bump: lockfile locked, re-scan for old API
- pnpm-lock.yaml correctly locks
@taskratchet/sdk@7.0.0- Ripgrep default ignores skipped files; rerun with
rg -nP -u "setAuthToken\s*\(" --glob "!.git/**" --glob "!node_modules/**"
to confirm no oldsetAuthToken(...)usages remain.src/components/organisms/NavBar.tsx (1)
14-14: Switch to setAuthTokenGetter aligns with SDK v7.Import change matches the new API. No issues spotted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the TaskRatchet SDK dependency, hopefully fixing an issue with the web app using stale clerk auth tokens.
Summary by CodeRabbit