This repository was archived by the owner on Oct 2, 2025. It is now read-only.
Add redirects for /login and /register paths to Clerk auth pages#180
Merged
Add redirects for /login and /register paths to Clerk auth pages#180
Conversation
Contributor
WalkthroughAdded Clerk redirect components and routes: imported Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Repository: TaskRatchet/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings📚 Learning: 2025-08-12T21:38:27.063ZApplied to files:
📚 Learning: 2025-08-16T19:53:45.147ZApplied to files:
Comment |
Outdated dependencies |
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Repository: TaskRatchet/coderabbit/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
src/App.tsx(2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: narthur
PR: TaskRatchet/taskratchet-web#166
File: global-setup.ts:25-25
Timestamp: 2025-08-12T21:38:27.063Z
Learning: The project uses __mocks__/clerk/clerk-react.tsx to provide mock implementations for Clerk authentication components and hooks instead of inline mocking in global-setup.ts. The mock file exports ClerkProvider, Protect, RedirectToSignIn, SignedIn, UserButton components and useUser/useClerk hooks with test-friendly return values.
📚 Learning: 2025-08-12T21:38:27.063Z
Learnt from: narthur
PR: TaskRatchet/taskratchet-web#166
File: global-setup.ts:25-25
Timestamp: 2025-08-12T21:38:27.063Z
Learning: The project uses __mocks__/clerk/clerk-react.tsx to provide mock implementations for Clerk authentication components and hooks instead of inline mocking in global-setup.ts. The mock file exports ClerkProvider, Protect, RedirectToSignIn, SignedIn, UserButton components and useUser/useClerk hooks with test-friendly return values.
Applied to files:
src/App.tsx
📚 Learning: 2025-08-16T19:53:45.147Z
Learnt from: narthur
PR: TaskRatchet/taskratchet-web#166
File: src/components/organisms/NavBar.tsx:40-49
Timestamp: 2025-08-16T19:53:45.147Z
Learning: In the TaskRatchet project, NavBar.spec.tsx still uses the old useSession mock and doesn't test the new Clerk authentication integration with useUser and useClerk hooks, so tests pass even when the Clerk mock returns session: null.
Applied to files:
src/App.tsx
🧬 Code graph analysis (1)
src/App.tsx (1)
__mocks__/@clerk/clerk-react.tsx (1)
RedirectToSignIn(11-13)
narthur
temporarily deployed
to
login-register-paths - tr-web PR #180
Render
Destroyed
coderabbitai bot
added a commit
that referenced
this pull request
Sep 29, 2025
Docstrings generation was requested by @narthur. * #180 (comment) The following files were modified: * `__mocks__/@clerk/clerk-react.tsx` * `src/App.tsx`
Contributor
|
Note Generated docstrings for this pull request at #181 |
This was referenced Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still links to /login and /register, so we can't actually remove them entirely. Instead we need to set them up to redirect to Clerk login and register pages. This PR makes the change.
Summary by CodeRabbit