Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23_setting_lint #25

Merged
merged 11 commits into from
Jan 9, 2024
Merged

23_setting_lint #25

merged 11 commits into from
Jan 9, 2024

Conversation

fridayCCC
Copy link
Contributor

요약

  • lefthook 사용
  • dev, qa, prod 모드 사용

이슈 번호

작업 내용

  • lefthook : githook과 연결해서 push 전에 lint 적용이 잘 되었는지 확인
  • dev, qa, prod 버전 main 파일 생성

추가 설명

  • 보안과 연관 있다고 생각되는 요소는 env파일로 관리할 예정

Copy link

github-actions bot commented Jan 8, 2024

Visit the preview URL for this PR (updated for commit 6b6054f):

https://taskweaver-front--pr25-23-setting-lint-d7zf321l.web.app

(expires Mon, 15 Jan 2024 16:29:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 37daec54a48dbfe281302dc48a4e028c965a31c2

@fridayCCC fridayCCC added this to the local login boilerplate milestone Jan 8, 2024
Copy link
Contributor

@brownglasses brownglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 확인했습니다 , 수고하셨습니다 ! git commitlint 를 통과하지 못했을 때 고치는데 많은 시간이 걸렸는데 도움이 되었습니다. 감사합니다

@jjoonleo
Copy link
Contributor

jjoonleo commented Jan 9, 2024

확인했습니다 수고하셨습니다. merge하겠습니다.

@jjoonleo jjoonleo merged commit 8e4ef56 into main Jan 9, 2024
4 checks passed
@fridayCCC fridayCCC deleted the 23_setting_lint branch January 13, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants