Skip to content

Messing around with display styling #12

Open
Gabbytam wants to merge 5 commits intoTaylorDarneille:masterfrom
Gabbytam:master
Open

Messing around with display styling #12
Gabbytam wants to merge 5 commits intoTaylorDarneille:masterfrom
Gabbytam:master

Conversation

@Gabbytam
Copy link

Deliverable Submission

Please describe your comfort and completeness levels before submitting.

Comfort Level (1-5): 1

Completeness Level (1-5): 4.5

Do you have any remaining questions about this deliverable?:
Can you do in-line styling on top of grid display?
What is the most efficient way to lay our your grid? I spent a considerable amount of time messing around with the grid-template portion of styling. I settled by using px but I feel like there's a more efficient way.

@ghost
Copy link

ghost commented Sep 5, 2020

Great questions!

  1. I believe you can do in-line styling on top of grid. In-line styles work over anything. Due to specificity, they will override anything in your stylesheet, and they are also read top to bottom, so later styles will override styles declared earlier
  2. Not sure exactly what you're referring to with regards to organizing your grid most efficiently, but I noticed you set identical grid info for each id. It would have been more efficient to give each of those elements a class of items, and to set the grid styles for the class instead of setting styles for each individual id.

as far as your styling, it looks great! 💯 go ahead and close out this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant