Fatima: Gabby Tam Loop Lab 8/25#13
Open
Gabbytam wants to merge 2 commits intoTaylorDarneille:masterfrom
Open
Conversation
ghost
reviewed
Sep 9, 2020
| console.log(phrases[randNum]); | ||
| } | ||
| i++; | ||
| } |
There was a problem hiding this comment.
nice! you've simulated the functionality of a for loop with a while loop. pretty cool! 😄
ghost
reviewed
Sep 9, 2020
| } else { | ||
| console.log(i); | ||
| } | ||
| } |
There was a problem hiding this comment.
double check this. 15 is getting caught in the fizz section.
the main idea here is to put the most specific condition first, as fewer of the numbers will get caught in it. so, lines 49-50 should be first, and the check against 3 and the check against 5 can happen after that
|
awesome! glad loops feel good to you. you did a great job with the assignment, marking complete 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I worked on this deliverable after working on the function deliverable and it seemed much easier by comparison! Feeling decent about loops.