Taylor Schmidt - Basic Loops Deliverable - Pod: Fatima#3
Open
taylorschmidt wants to merge 2 commits intoTaylorDarneille:masterfrom
Open
Taylor Schmidt - Basic Loops Deliverable - Pod: Fatima#3taylorschmidt wants to merge 2 commits intoTaylorDarneille:masterfrom
taylorschmidt wants to merge 2 commits intoTaylorDarneille:masterfrom
Conversation
ghost
reviewed
Sep 9, 2020
| let x = Math.floor(Math.random() * 4) | ||
| console.log(catTalk[x]) | ||
| } | ||
| } |
|
nice work! all your code looks well thought-out. the only thing I would pick on is your indentation -- make sure functions / loops / conditionals in the global scope are as far left as possible, and that closing mustaches are at the same level as the line where the corresponding opening mustache is. marking complete ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was mostly comfortable with this deliverable, with the exception of the cat problem. I tried many methods before realizing that I needed to put all of the cat's phrases into an array. Then, problem solved!