fixed an issue with profiles containing invalid time values on Blizza…

…rd pages (negative)

overfastapi/common/helpers.py

@@ -25,6 +25,7 @@
 # List of players used for testing
 players_ids = [
     "Dekk-2677",  # Classic profile without rank
+    "KIRIKO-21253",  # Profile with rank on only two roles
     "Player-1112937",  # Console player
     "Player-137712",  # Private profile
     "SoSucre-2795",  # Top player Open Queue

overfastapi/parsers/helpers.py

@@ -13,7 +13,7 @@ def get_computed_stat_value(input_str: str) -> str | float | int:
     """
 
     # Duration format in hour:min:sec => seconds
-    result = re.match(r"^([0-9]+[,]?[0-9]*?):([0-9]+):([0-9]+)$", input_str)
+    result = re.match(r"^([-]?[0-9]+[,]?[0-9]*?):([0-9]+):([0-9]+)$", input_str)
     if result:
         return (
             int(result.group(1).replace(",", "")) * 3600
@@ -22,7 +22,7 @@ def get_computed_stat_value(input_str: str) -> str | float | int:
         )
 
     # Duration format in min:sec => seconds
-    result = re.match(r"^([0-9]+):([0-9]+)$", input_str)
+    result = re.match(r"^([-]?[0-9]+):([0-9]+)$", input_str)
     if result:
         return int(result.group(1)) * 60 + int(result.group(2))
 

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "overfast-api"
-version = "2.3.0"
+version = "2.3.1"
 description = "Overwatch API giving data about heroes, maps, and players statistics."
 authors = ["TeKrop <tekrop@gmail.com>"]
 license = "MIT"

tests/parsers/test_helpers.py

@@ -24,11 +24,13 @@
         ("205:08:38", 738518),
         ("12:03:52", 43432),
         ("5:42:42", 20562),
+        ("-0:00:00", 0),
         # Time format in min:sec => seconds
         ("11:40", 700),
         ("04:10", 250),
         ("07:55", 475),
         ("00:11", 11),
+        ("-00:00", 0),
         # Int format
         ("0", 0),
         ("5", 5),