fix: fixed two issues with Blizzard profiles (#166)

* fix: fixed two issues with Blizzard profiles

* bump version

app/parsers/helpers.py

@@ -35,8 +35,11 @@ def get_computed_stat_value(input_str: str) -> str | float | int:
     if re.match(r"^-?\d+\.\d+$", input_str):
         return float(input_str)
 
-    # Zero time fought with a character if "--", else default value
-    return 0 if input_str == "--" else input_str
+    # Return 0 value if :
+    # - Zero time fought with a character ("--")
+    # - Invalid value in DOM ("NaN")
+    # Else default value
+    return 0 if input_str in {"--", "NaN"} else input_str
 
 
 def get_division_from_icon(rank_url: str) -> CompetitiveDivision:

app/parsers/player_parser.py

@@ -365,7 +365,12 @@ def __get_heroes_comparisons(self, top_heroes_section: Tag) -> dict:
         }
 
         for category in CareerHeroesComparisonsCategory:
-            if category.value not in heroes_comparisons:
+            # Sometimes, Blizzard exposes the categories without any value
+            # In that case, we must assume we have no data at all
+            if (
+                category.value not in heroes_comparisons
+                or not heroes_comparisons[category.value]["values"]
+            ):
                 heroes_comparisons[category.value] = None
 
         return heroes_comparisons

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "overfast-api"
-version = "2.32.0"
+version = "2.32.1"
 description = "Overwatch API giving data about heroes, maps, and players statistics."
 license = "MIT"
 authors = ["Valentin PORCHET <valentin.porchet@proton.me>"]

tests/parsers/test_helpers.py

@@ -34,6 +34,8 @@
         ("-86.96", -86.96),
         # Zero time fought with a character
         ("--", 0),
+        # Invalid value (not a number)
+        ("NaN", 0),
         # Default value for anything else
         ("string", "string"),
     ],