Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: made status page URL configurable and added description about live instance rate limits #97

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

TeKrop
Copy link
Owner

@TeKrop TeKrop commented Feb 20, 2024

No description provided.

@TeKrop TeKrop added the enhancement New feature or request label Feb 20, 2024
@TeKrop TeKrop self-assigned this Feb 20, 2024
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request introduces enhancements to the OverFast API project by making the status page URL configurable and adding a description about the live instance rate limits. Specifically, it updates the README.md to inform users about the rate limit of 30 requests per second for the live instance and suggests hosting their own instance if more is required. In the app's configuration, it adds an optional status page URL setting, allowing for flexibility in providing a status page. Additionally, the main application's description has been revised to more accurately reflect the project's capabilities and efficiency improvements.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Consider adding more detailed documentation or examples on how to set up and use the new status page URL configuration for new users or contributors.
  • It might be beneficial to include information on how users can monitor their usage against the rate limit or how they can request an increase if hosting their own instance.
  • Review the new project description to ensure it aligns with all aspects of the project's goals and capabilities, ensuring no key features or selling points are omitted.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@TeKrop TeKrop merged commit 43cf8a1 into main Feb 20, 2024
2 checks passed
@TeKrop TeKrop deleted the feature/status-page-and-rate-limit-description branch February 20, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant