Skip to content

Commit

Permalink
refactor :: 콘솔 오류 제거 #22
Browse files Browse the repository at this point in the history
  • Loading branch information
s1hyun2 committed Oct 11, 2024
1 parent 4694fbb commit c938541
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 24 deletions.
2 changes: 1 addition & 1 deletion src/components/common/FallbackSkeleton/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const FallbackSkeleton = () => {
<>
<SkeletonContainer>
{Array.from({ length: 6 }).map((_, idx) => (
<SkeletonItem />
<SkeletonItem key={idx} />
))}
</SkeletonContainer>
</>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,17 @@ const HomeScheduleSideBarHeaderDropdown = () => {

return (
<HomeScheduleSideBarHeaderDropdownContainer
onClick={() => setFold((prev) => !prev)}
>
onClick={() => setFold((prev) => !prev)}>
{classificationKeyword}
<HomeScheduleSideBarHeaderDropdownIcon fold={fold}>
<BsFillTriangleFill />
</HomeScheduleSideBarHeaderDropdownIcon>
{!fold && (
<HomeScheduleSideBarHeaderDropdownWrap>
{HOME_SCHEDULE_SIDE_BAR_HEADER_DROPDOWN_ITEMS.map((item) => (
{HOME_SCHEDULE_SIDE_BAR_HEADER_DROPDOWN_ITEMS.map((item, idx) => (
<HomeScheduleSideBarHeaderDropdownItem
onClick={() => setClassificationKeyword(item)}
>
key={idx}>
{item}
</HomeScheduleSideBarHeaderDropdownItem>
))}
Expand All @@ -40,4 +39,4 @@ const HomeScheduleSideBarHeaderDropdown = () => {
);
};

export default HomeScheduleSideBarHeaderDropdown;
export default HomeScheduleSideBarHeaderDropdown;
34 changes: 17 additions & 17 deletions src/hooks/schedule/useHomeSidebarSchedule.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import dayjs from "dayjs";
import { useEffect, useState } from "react";
import { useCallback, useEffect, useState } from "react";
import { useRecoilValue } from "recoil";
import { useGetMember } from "../../queries/member/member.query";
import { useGetSchedulesByDate } from "../../queries/schedule/schedule.query";
Expand All @@ -20,21 +20,21 @@ const useHomeSidebarSchedule = () => {
{ suspense: true },
);

const loadMyGradeSchedules = () => {
setSchedules(
schedulesData?.data.filter(
(schedule) =>
schedule.targetGrades[0].indexOf(String(memberData?.data.student.grade)) > -1 ||
schedule.targetGrades[0] === "전교생",
)!,
);
};

const loadAllSchedules = () => {
setSchedules(schedulesData!.data);
};
const handleSchedules = useCallback((scope: string) => {
const loadMyGradeSchedules = () => {
setSchedules(
schedulesData?.data.filter(
(schedule) =>
schedule.targetGrades[0].indexOf(String(memberData?.data.student.grade)) > -1 ||
schedule.targetGrades[0] === "전교생",
)!,
);
};

const loadAllSchedules = () => {
setSchedules(schedulesData!.data);
};

const handleSchedules = (scope: string) => {
setSchedules([]);

switch (scope) {
Expand All @@ -50,13 +50,13 @@ const useHomeSidebarSchedule = () => {
loadAllSchedules();
break;
}
};
}, [memberData?.data.student.grade, schedulesData]);

useEffect(() => {
if (schedulesData?.data) {
handleSchedules(classificationKeyword);
}
}, [schedulesData?.data, classificationKeyword]);
}, [schedulesData?.data, classificationKeyword, handleSchedules]);

return {
schedules,
Expand Down
2 changes: 1 addition & 1 deletion src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ root.render(
// If you want to start measuring performance in your app, pass a function
// to log results (for example: reportWebVitals(console.log))
// or send to an analytics endpoint. Learn more: https://bit.ly/CRA-vitals
reportWebVitals();
reportWebVitals();

0 comments on commit c938541

Please sign in to comment.