[스테디] 스테디 인기 모집글 조회 API 개발 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @GetMapping을 사용하여 /rank 에 인기 스터디 목록 조회 API 구현 - RankParams를 통해 전달된 조건에 따라 목록 반환
- `steadyRepository`의 `findPopularStudyInCondition` 메소드를 사용하여 조건에 맞는 인기 스터디
- 프로모션 날짜, 스터디 유형 조건으로 필터링 및 좋아요와 조회수로 정렬
- getXXX -> findXXX
- Eager -> Lazy
Test Results 27 files 27 suites 8s ⏱️ Results for commit 8c74715. |
K-jun98
requested review from
weonest and
na-yk
and removed request for
weonest
weonest
approved these changes
Jan 3, 2024
Comment on lines
+9
to
+15
| public record RankParams( | ||
| @DateTimeFormat(pattern = "yyyy-MM-dd") | ||
| LocalDate date, | ||
| @Max(value = 10, message = "인기글은 최대 10개까지 조회가 가능합니다.") | ||
| int limit, | ||
| String type | ||
| ) { |
There was a problem hiding this comment.
limit에 Max 값을 지정해줌으로써 예상치 못한 서버 에러를 방지하는 모습이 좋은 것 같습니다!
| public List<Steady> findPopularStudyInCondition(RankCondition condition) { | ||
| return jpaQueryFactory.selectFrom(steady) | ||
| .where(steady.promotion.promotedAt | ||
| .after(condition.date().atStartOfDay()), |
There was a problem hiding this comment.
atStartOfDay로 자료형을 맞춰주시는 부분이 좋은 것 같네요!
| @@ -80,6 +83,19 @@ public static Steady createSteady(User leader, List<Stack> stacks) { | |||
| .build(); | |||
| } | |||
|
|
|||
| public static List<Steady> createSteadiesWithLikeCount(User leader, List<Stack> stacks, int likeCount) { | |||
| return IntStream.rangeClosed(0, likeCount) | |||
There was a problem hiding this comment.
rangeClosed를 사용하여 마지막 값을 포함하신 이유가 있을까요?
There was a problem hiding this comment.
마지막값을 포함한다는걸 좀 더 명확하게 하고싶어서 사용했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR 체크리스트
💡 어떤 작업을 하셨나요?
Issue Number : close #194
작업 내용
스테디 인기 모집글 조회 API 개발 및 문서화
📝리뷰어에게
인기글의 대한 기준은 선택한 날짜 이후의 모집글에서 좋아요 수,조회수 를 기준으로 산정했습니다.(좋아요 수가 같다면 조회수 순)
요청에 limit param을 추가해 클라이언트에서 모집글 갯수(10이하)를 지정할 수 있게했습니다.