[FEAT] 홈 API 구현 #34
Merged
[FEAT] 홈 API 구현 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
ddongseop
requested changes
Jan 6, 2024
Comment on lines
13
to
14
| public class | ||
| Note extends BaseTimeEntity { |
There was a problem hiding this comment.
[P2] 여기 불필요한 엔터가 들어간 것 같아요! 수정 부탁드림당~
Comment on lines
11
to
12
| @Query(value = "select b from Book b where b.isPopular = :isPopular") | ||
| List<Book> getAllByPopular(@Param("isPopular") Boolean isPopular, PageRequest pageRequest); |
There was a problem hiding this comment.
[P3] 혹시 여기 Book 뒤에 띄어쓰기 한번 더 들어간거 같은데 수정해주실 수 있나요~?
Comment on lines
+62
to
+74
| public Book(String uuid, String favoriteName, String favoriteImage, String title, String description, int backgroundColor, Member member, boolean isPopular) { | ||
| this.uuid = uuid; | ||
| this.favoriteName = favoriteName; | ||
| this.favoriteImage = favoriteImage; | ||
| this.title = title; | ||
| this.description = description; | ||
| this.backgroundColor = backgroundColor; | ||
| this.member = member; | ||
| this.isPopular = isPopular; | ||
| } | ||
|
|
||
| public static Book of(String uuid, String favoriteName, String favoriteImage, String title, String description, int backgroundColor, Member member) { | ||
| return new Book(uuid, favoriteName, favoriteImage, title, description, backgroundColor, member); | ||
| public static Book of(String uuid, String favoriteName, String favoriteImage, String title, String description, int backgroundColor, Member member, boolean isPopular) { | ||
| return new Book(uuid, favoriteName, favoriteImage, title, description, backgroundColor, member, isPopular); |
|
|
||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class InitDb { |
There was a problem hiding this comment.
InitDb 만드는거 귀찮은 작업인데,,, 맛있게 쓰겠습니다,,,
eeddiinn
approved these changes
Jan 7, 2024
| private final BookRepository bookRepository; | ||
|
|
||
| public List<Book> getPopularBook() { | ||
| return bookRepository.getAllByPopular(true, PageRequest.of(0, 6)); |
There was a problem hiding this comment.
오호 PageRequest에 대해 새롭게 알고갑니다 !!!! 😁
# Conflicts: # src/main/java/org/sopt/lequuServer/domain/book/service/BookService.java # src/main/java/org/sopt/lequuServer/global/exception/enums/SuccessType.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
closed #8
✨ 어떤 이유로 변경된 내용인지
🙏 검토 혹은 리뷰어에게 남기고 싶은 말