[FEAT] 마이페이지 조회 API 구현 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dong2ast
reviewed
Jan 10, 2024
There was a problem hiding this comment.
[P3] QueryDSL 기능을 이용하면 더 좋은 방식으로 불러올 수도 있을 것 같네요~
나중에 리팩토링 해봅시다~
Comment on lines
22
to
30
| if (background.endsWith(".jpg")) { | ||
| return new MypageNoteListResponseDto(note.getBook().getUuid(), note.getBook().getTitle(), | ||
| note.getId(), note.getContent(), | ||
| noteDate, -1, background); | ||
| } else { | ||
| return new MypageNoteListResponseDto(note.getBook().getUuid(), note.getBook().getTitle(), | ||
| note.getId(), note.getContent(), | ||
| noteDate, Integer.parseInt(background), ""); | ||
| } |
There was a problem hiding this comment.
[P2] 클린코드를 위해서는 else 예약어 사용을 지양하는 편이 좋다고 합니다!
위 코드는
Suggested change
| if (background.endsWith(".jpg")) { | |
| return new MypageNoteListResponseDto(note.getBook().getUuid(), note.getBook().getTitle(), | |
| note.getId(), note.getContent(), | |
| noteDate, -1, background); | |
| } else { | |
| return new MypageNoteListResponseDto(note.getBook().getUuid(), note.getBook().getTitle(), | |
| note.getId(), note.getContent(), | |
| noteDate, Integer.parseInt(background), ""); | |
| } | |
| if (background.endsWith(".jpg")) { | |
| return new MypageNoteListResponseDto(note.getBook().getUuid(), note.getBook().getTitle(), | |
| note.getId(), note.getContent(), | |
| noteDate, -1, background); | |
| } | |
| return new MypageNoteListResponseDto(note.getBook().getUuid(), note.getBook().getTitle(), | |
| note.getId(), note.getContent(), | |
| noteDate, Integer.parseInt(background), ""); |
이렇게 바꿀 수 있겠네요 :)
Comment on lines
8
to
19
| public record MypageNoteResponseDto( | ||
|
|
||
| List<MypageNoteListResponseDto> mypageNoteList | ||
| ) { | ||
| public static MypageNoteResponseDto of(List<Note> notes) { | ||
| List<MypageNoteListResponseDto> mypageNoteList = notes.stream() | ||
| .map(MypageNoteListResponseDto::of) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| return new MypageNoteResponseDto(mypageNoteList); | ||
| } | ||
| } |
There was a problem hiding this comment.
[P3] DTO 리스트가 단일 필드로 들어가 있는거면 따로 감싸지 않고 그대로 반환하는 것은 어떤가요?
감싸는 것이 좋은 이유가 있다면 알려주세요~
dong2ast
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
closed #11
✨ 어떤 이유로 변경된 내용인지
마이페이지 조회 api 를 구현했습니다.
마이페이지 내 레큐북 조회 api를 구현했습니다.
마이페이지 내 레큐노트 조회 api를 구현했습니다.
🙏 검토 혹은 리뷰어에게 남기고 싶은 말
Dto 이름 더 보기 좋은 것으로 추천해주세용 ~~~~~!!
아 노트 생성 부분 이미지랑 색으로 나눠버렸는데 다시 수정해야될 것 같아요 허허 - 수정완료 !!