Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 윤한이형 피드백 반영 #67

Merged
merged 9 commits into from
Jan 17, 2024
Merged

[FIX] 윤한이형 피드백 반영 #67

merged 9 commits into from
Jan 17, 2024

Conversation

ddongseop
Copy link
Member

📌 관련 이슈

closed #65

✨ 어떤 이유로 변경된 내용인지

  • 스웨거를 인터페이스로 분리
  • 필드명에서 List 사용 삭제
  • ResponseEntity 사용
  • 이미지 테스트용 TestController 삭제
  • dto 파라미터명 통일

🙏 검토 혹은 리뷰어에게 남기고 싶은 말

@ddongseop ddongseop added ddongseop🔥 🔧Modify 코드 수정 (기능의 변화가 있을 때) 🔥 Pull Request PR 날림 🔨Refactor 코드 리팩토링 (기능 변경 없이 코드만 수정할 때) labels Jan 16, 2024
@ddongseop ddongseop self-assigned this Jan 16, 2024
eeddiinn
eeddiinn approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@eeddiinn eeddiinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

야무지 야무지네요! 수고하셨습니당 :)

dong2ast
dong2ast approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@dong2ast dong2ast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생요~ 👍

src/main/java/org/sopt/lequuServer/domain/book/controller/BookApi.java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 이렇게 API를 분리하는군요~ 신기하네요!

@ddongseop ddongseop merged commit 9a07237 into develop Jan 17, 2024
1 check passed
@ddongseop ddongseop deleted the fix/#65-apply_unan_feedback branch January 17, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dong2ast dong2ast dong2ast approved these changes

@eeddiinn eeddiinn eeddiinn approved these changes

Assignees

@ddongseop ddongseop

Labels
ddongseop🔥 🔧Modify 코드 수정 (기능의 변화가 있을 때) 🔥 Pull Request PR 날림 🔨Refactor 코드 리팩토링 (기능 변경 없이 코드만 수정할 때)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 윤한이형 피드백 반영
3 participants
@ddongseop @dong2ast @eeddiinn