[REFACTOR] 원본 이미지 대신 압축된 썸네일을 반환하도록 수정#140
Merged
jaemin0413 merged 5 commits intodevfrom Feb 14, 2026
Merged
Conversation
3 tasks
📝 WalkthroughWalkthrough이 PR은 이미지 URL 참조를 썸네일 URL로 전환하고 Image 엔티티에 Changes
Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/main/java/com/umc/nuvibe/domain/home/service/HomeServiceImpl.java (1)
78-83:⚠️ Potential issue | 🟡 Minor
Collectors.toMap에서getThumbnailUrl()이null을 반환하면 NPE 발생
getThumbnailUrl()은thumbnailUrl과imageUrl이 모두null인 경우null을 반환합니다.Collectors.toMap은null값을 허용하지 않아NullPointerException이 발생합니다.
imageUrl이 항상 설정되어 있다면 실질적 문제는 아니지만, 방어적으로 처리하는 것이 안전합니다.방어적 처리 예시
Map<Long, String> thumbnailMap = boardImageRepository.findLatestByBoardIds(boardIds) .stream() .collect(Collectors.toMap( bi -> bi.getBoard().getId(), - bi -> bi.getImage().getThumbnailUrl(), + bi -> Optional.ofNullable(bi.getImage().getThumbnailUrl()).orElse(""), (existing, replacement) -> existing));src/main/java/com/umc/nuvibe/domain/tribe/dto/response/chat/ChatGridItemRes.java (1)
19-20: 🧹 Nitpick | 🔵 TrivialSwagger
@Schema설명이 실제 반환 값과 불일치
imageUrl필드가 이제 썸네일 URL을 반환하지만,@Schema(description = "이미지 URL (S3 경로)")는 여전히 원본 이미지를 암시합니다. API 문서의 정확성을 위해 설명을 업데이트하는 것을 권장합니다. 동일한 패턴을 사용하는 다른 DTO(ChatDetailRes,ChatTimelineItemRes등)도 확인해 보세요.
🤖 Fix all issues with AI agents
In `@src/main/java/com/umc/nuvibe/domain/image/entity/Image.java`:
- Around line 49-54: getThumbnailUrl() falls back to imageUrl when thumbnailUrl
is null or blank but the JPQL uses COALESCE(img.thumbnailUrl, img.imageUrl)
which treats empty string as a valid value; make behavior consistent by either
updating the JPQL in ScrapedImageRepository to treat empty string as null (e.g.,
use COALESCE(NULLIF(img.thumbnailUrl, ''), img.imageUrl) or a CASE/NULLIF
variant) or normalize blank thumbnailUrl to null on persist/update (e.g., in the
Image entity setter for thumbnailUrl or in the repository before saving) so
getThumbnailUrl(), the DB query, and stored data all behave the same.
In `@src/main/java/com/umc/nuvibe/domain/image/service/ImageServiceImpl.java`:
- Around line 43-44: In ImageServiceImpl where you compute pureFileName from
preSignedUrl.fileName(), don't use String.replace which removes all "raw/"
occurrences; instead call replaceFirst with a prefix-only regex (e.g.,
replaceFirst("^raw/", "")) or explicitly check startsWith and strip the leading
segment so only the leading "raw/" is removed (update the assignment to
pureFileName accordingly).
In
`@src/main/java/com/umc/nuvibe/domain/tribe/dto/response/chat/ChatDetailRes.java`:
- Line 36: ChatDetailRes currently returns image.getThumbnailUrl() but per PR
requirements the 채팅 이미지 상세 조회 응답 must return the original image URL; update the
response construction in ChatDetailRes to use image.getImageUrl() (replace any
reference to getThumbnailUrl() for the detailed response) so the original image
URL is returned while keeping thumbnail usage unchanged elsewhere.
In `@src/main/java/com/umc/nuvibe/global/scheduler/ImageCleanupScheduler.java`:
- Around line 56-64: The PENDING-image cleanup only deletes the raw/ object and
can leave an orphaned thumbnail; update ImageCleanupScheduler to also delete the
thumbnail when image.getThumbnailUrl() is non-null/non-blank: extract the S3 key
from image.getThumbnailUrl() (or use it directly if your s3Service expects a
key), call s3Service.deleteFile(thumbnailKey) the same way you call
s3Service.deleteFile(rawPath), and log success/failure similarly; place this
logic alongside the existing raw/ deletion and use image.getThumbnailUrl(),
image.getFileName(), and s3Service.deleteFile(...) to locate and remove the
thumbnail.
In `@src/main/java/com/umc/nuvibe/global/service/ImageEventListener.java`:
- Around line 51-54: The current ImageEventListener lambda logs orphaned fileIds
but doesn't remove the corresponding S3 objects; update the lambda in
ImageEventListener where log.warn("DB에 존재하지 않는 fileId: {}", event.fileId()) is
called to remove S3 originals/thumbnails for that event.fileId(): build the S3
object keys (original and thumbnail naming used elsewhere), call the S3 client
delete (or batch delete) for those keys (or enqueue the keys to an async cleanup
queue/job if you prefer eventual deletion), handle and log any exceptions from
the S3 operation, and ensure deletions are idempotent so repeated events won't
fail.
- Around line 22-26: The required-field check should also validate the event's
status to make intent explicit: add event.status() == null to the existing
null-check condition that currently tests event.fileId(), event.originalUrl(),
and event.thumbnailUrl(); update the if condition in ImageEventListener to
return after logging the same warning if any of those including event.status()
are null so the later `"SUCCESS".equals(event.status())` scenario is never
evaluated against null.
Comment on lines
+49
to
+54
| // 썸네일 URL이 없으면 원본 URL을 반환 | ||
| public String getThumbnailUrl() { | ||
| return (thumbnailUrl != null && !thumbnailUrl.isBlank()) | ||
| ? thumbnailUrl | ||
| : imageUrl; | ||
| } |
There was a problem hiding this comment.
getThumbnailUrl()의 폴백 로직과 JPQL COALESCE의 동작 불일치
이 메서드는 thumbnailUrl이 null이거나 빈 문자열일 때 imageUrl로 폴백하지만, ScrapedImageRepository의 JPQL에서는 COALESCE(img.thumbnailUrl, img.imageUrl)을 사용하여 NULL만 체크합니다. thumbnailUrl이 빈 문자열("")인 경우 Java 측에서는 imageUrl을 반환하지만 JPQL 측에서는 빈 문자열을 그대로 반환하게 됩니다.
일관성을 위해 JPQL 쿼리에서도 빈 문자열을 처리하거나, 저장 시점에서 빈 문자열이 들어오지 않도록 보장해야 합니다.
JPQL 쪽 수정 예시 (ScrapedImageRepository)
- COALESCE(img.thumbnailUrl, img.imageUrl)
+ CASE WHEN img.thumbnailUrl IS NOT NULL AND img.thumbnailUrl <> '' THEN img.thumbnailUrl ELSE img.imageUrl END🤖 Prompt for AI Agents
In `@src/main/java/com/umc/nuvibe/domain/image/entity/Image.java` around lines 49
- 54, getThumbnailUrl() falls back to imageUrl when thumbnailUrl is null or
blank but the JPQL uses COALESCE(img.thumbnailUrl, img.imageUrl) which treats
empty string as a valid value; make behavior consistent by either updating the
JPQL in ScrapedImageRepository to treat empty string as null (e.g., use
COALESCE(NULLIF(img.thumbnailUrl, ''), img.imageUrl) or a CASE/NULLIF variant)
or normalize blank thumbnailUrl to null on persist/update (e.g., in the Image
entity setter for thumbnailUrl or in the repository before saving) so
getThumbnailUrl(), the DB query, and stored data all behave the same.
Comment on lines
+43
to
+44
| // fileName에서 prefix 제거 | ||
| String pureFileName = preSignedUrl.fileName().replace("raw/", ""); |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
replace 대신 replaceFirst 사용 권장
String.replace("raw/", "")는 문자열 내 모든 "raw/" 발생을 제거합니다. 접두사만 제거하려는 의도라면 replaceFirst가 더 안전합니다.
수정 제안
- String pureFileName = preSignedUrl.fileName().replace("raw/", "");
+ String pureFileName = preSignedUrl.fileName().replaceFirst("^raw/", "");📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // fileName에서 prefix 제거 | |
| String pureFileName = preSignedUrl.fileName().replace("raw/", ""); | |
| // fileName에서 prefix 제거 | |
| String pureFileName = preSignedUrl.fileName().replaceFirst("^raw/", ""); |
🤖 Prompt for AI Agents
In `@src/main/java/com/umc/nuvibe/domain/image/service/ImageServiceImpl.java`
around lines 43 - 44, In ImageServiceImpl where you compute pureFileName from
preSignedUrl.fileName(), don't use String.replace which removes all "raw/"
occurrences; instead call replaceFirst with a prefix-only regex (e.g.,
replaceFirst("^raw/", "")) or explicitly check startsWith and strip the leading
segment so only the leading "raw/" is removed (update the assignment to
pureFileName accordingly).
src/main/java/com/umc/nuvibe/domain/tribe/dto/response/chat/ChatDetailRes.java
Outdated
Show resolved
Hide resolved
Comment on lines
+56
to
64
| // Lambda 시스템에서는 raw/ prefix를 추가해야 함 | ||
| if (image.getFileName() != null && !image.getFileName().isBlank()) { | ||
| s3Deleted = s3Service.deleteFile(image.getFileName()); | ||
| String rawPath = "raw/" + image.getFileName(); | ||
| s3Deleted = s3Service.deleteFile(rawPath); | ||
| if (s3Deleted) { | ||
| log.info("S3 파일 삭제 성공 - ID: {}, FileName: {}", image.getId(), image.getFileName()); | ||
| log.info("S3 파일 삭제 성공 - ID: {}, Path: {}", image.getId(), rawPath); | ||
| } else { | ||
| log.warn("S3 파일 삭제 실패 - ID: {}, FileName: {}", image.getId(), image.getFileName()); | ||
| log.warn("S3 파일 삭제 실패 - ID: {}, Path: {}", image.getId(), rawPath); | ||
| } |
There was a problem hiding this comment.
PENDING 이미지 정리 시 썸네일 파일도 삭제가 필요할 수 있음
Lambda가 raw/ 파일을 처리하여 썸네일을 이미 생성했지만, 이미지 상태가 아직 ACTIVE로 전환되지 않은 경우(경합 조건), raw/ 파일만 삭제하면 S3에 고아 썸네일 파일이 남을 수 있습니다.
발생 확률이 낮은 엣지 케이스이지만, thumbnailUrl이 설정된 PENDING 이미지가 있다면 해당 썸네일 경로도 함께 삭제하는 것을 고려해 보세요.
🤖 Prompt for AI Agents
In `@src/main/java/com/umc/nuvibe/global/scheduler/ImageCleanupScheduler.java`
around lines 56 - 64, The PENDING-image cleanup only deletes the raw/ object and
can leave an orphaned thumbnail; update ImageCleanupScheduler to also delete the
thumbnail when image.getThumbnailUrl() is non-null/non-blank: extract the S3 key
from image.getThumbnailUrl() (or use it directly if your s3Service expects a
key), call s3Service.deleteFile(thumbnailKey) the same way you call
s3Service.deleteFile(rawPath), and log success/failure similarly; place this
logic alongside the existing raw/ deletion and use image.getThumbnailUrl(),
image.getFileName(), and s3Service.deleteFile(...) to locate and remove the
thumbnail.
Comment on lines
+22
to
26
| // 필수 필드 검증 | ||
| if (event.fileId() == null || event.originalUrl() == null || event.thumbnailUrl() == null) { | ||
| log.warn("잘못된 Lambda 메시지 수신: {}", event); | ||
| return; | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
status 필드도 null 검증에 포함하는 것이 안전합니다.
현재 status가 null인 경우 line 29의 "SUCCESS".equals(null)이 false를 반환하여 에러로 처리되지만, 이는 의도가 불명확합니다. 필수 필드 검증에 status를 포함하면 의미가 명확해집니다.
♻️ 수정 제안
- if (event.fileId() == null || event.originalUrl() == null || event.thumbnailUrl() == null) {
+ if (event.fileId() == null || event.originalUrl() == null || event.thumbnailUrl() == null || event.status() == null) {🤖 Prompt for AI Agents
In `@src/main/java/com/umc/nuvibe/global/service/ImageEventListener.java` around
lines 22 - 26, The required-field check should also validate the event's status
to make intent explicit: add event.status() == null to the existing null-check
condition that currently tests event.fileId(), event.originalUrl(), and
event.thumbnailUrl(); update the if condition in ImageEventListener to return
after logging the same warning if any of those including event.status() are null
so the later `"SUCCESS".equals(event.status())` scenario is never evaluated
against null.
Comment on lines
+51
to
+54
| () -> { | ||
| log.warn("DB에 존재하지 않는 fileId: {}", event.fileId()); | ||
| // Lambda가 생성한 파일이지만 DB에 없는 경우 (고아 파일) | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
고아 파일 정리 로직이 누락되어 있습니다.
DB에 존재하지 않는 fileId에 대해 Lambda가 생성한 original/thumbnail 파일이 S3에 남게 됩니다. 시간이 지남에 따라 불필요한 스토리지 비용이 누적될 수 있으므로, S3 파일 삭제 처리 또는 별도 배치 정리 작업을 추가하는 것을 권장합니다.
🤖 Prompt for AI Agents
In `@src/main/java/com/umc/nuvibe/global/service/ImageEventListener.java` around
lines 51 - 54, The current ImageEventListener lambda logs orphaned fileIds but
doesn't remove the corresponding S3 objects; update the lambda in
ImageEventListener where log.warn("DB에 존재하지 않는 fileId: {}", event.fileId()) is
called to remove S3 originals/thumbnails for that event.fileId(): build the S3
object keys (original and thumbnail naming used elsewhere), call the S3 client
delete (or batch delete) for those keys (or enqueue the keys to an async cleanup
queue/job if you prefer eventual deletion), handle and log any exceptions from
the S3 operation, and ensure deletions are idempotent so repeated events won't
fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎋 이슈 및 작업중인 브랜치
🔑 주요 내용
Check List
Summary by CodeRabbit
Bug Fixes
Refactor