Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fetching admin list from SFTP source #385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pavelhoral
Copy link
Contributor

@pavelhoral pavelhoral commented Oct 13, 2024

This PR adds support for fetching Admins.cfg file from SFTP source. I have also replaced manual regex based URL parsing with NodeJS's URL parsing.

I have tested both FTP and SFTP using local docker containers (https://github.com/garethflowers/docker-ftp-server and https://docs.sftpgo.com/).

I have used ssh2-sftp-client package because this exact package is being used by the current ftp-tail dependency (https://github.com/Thomas-Smyth/ftp-tail/). The major version is increased from 10 to 11, but I don't think that should break anything.

Copy link
Collaborator

@werewolfboy13 werewolfboy13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies on the delay, this needs to be corrected to use the templates.

@pavelhoral
Copy link
Contributor Author

Apologies on the delay, this needs to be corrected to use the templates.

I am not sure I follow what needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants